Skip to content

Add basic MacOS support#224

Merged
fdw merged 1 commit into
fdw:mainfrom
Lqp1:main
Jul 8, 2025
Merged

Add basic MacOS support#224
fdw merged 1 commit into
fdw:mainfrom
Lqp1:main

Conversation

@Lqp1
Copy link
Copy Markdown
Contributor

@Lqp1 Lqp1 commented Jul 6, 2025

As discussed in #223, here is a PR to add basic support for MacOS to Rofimoji

Copy link
Copy Markdown
Owner

@fdw fdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very nice already, thank you very much! Looking forward to merging it 🙂

Comment thread src/picker/abstractionhelper.py Outdated
Comment thread src/picker/clipboarder/pbcopy.py Outdated
Comment thread src/picker/clipboarder/pbcopy.py
Comment thread src/picker/selector/choose.py Outdated
)

def type_numerical(self, codepoints: List[int], active_window: str) -> None:
pass
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might work if there's a compose key on Mac.

Comment thread src/picker/typer/cliclick.py
Comment thread README.md Outdated
@Lqp1
Copy link
Copy Markdown
Contributor Author

Lqp1 commented Jul 7, 2025

Btw, here are the actions I tested:

  • menu action triggers properly with choose, including the colour selection for the valid emojis
  • copy-unicode, clipboard and copy actions work as expected (validating pbcopy, pbpaste and the cliclick setup).

Works inside a terminal & on regular windows

@fdw
Copy link
Copy Markdown
Owner

fdw commented Jul 8, 2025

After you've changed the conditions for the helpers, squash the commits and I think it's ready to be merged 🥳

@Lqp1
Copy link
Copy Markdown
Contributor Author

Lqp1 commented Jul 8, 2025

I addressed the last comments - I don't have the time yet to dig the type_numerical missing feature in the typer, so I'll let you see if you prefer a complete implementation or if current state is already good enough as a first step :)

@Lqp1 Lqp1 marked this pull request as ready for review July 8, 2025 15:57
@fdw
Copy link
Copy Markdown
Owner

fdw commented Jul 8, 2025

Sorry, ruff still has problems. Could you fix those, please?

* Add choose as rofi alternative
* Support pbcopy/pbpaste backend for clipboarder
* Add cliclick support as typer
* Update documentation

Implements: fdw#223
@Lqp1
Copy link
Copy Markdown
Contributor Author

Lqp1 commented Jul 8, 2025

Indeed, forgot to clean/order imports, sorry about that

@fdw fdw merged commit 1438d04 into fdw:main Jul 8, 2025
5 checks passed
@fdw
Copy link
Copy Markdown
Owner

fdw commented Jul 8, 2025

Awesome, thank you very much!

@Lqp1
Copy link
Copy Markdown
Contributor Author

Lqp1 commented Jul 8, 2025

Thanks for your support!

Lqp1 added a commit to Lqp1/nixpkgs that referenced this pull request Jan 15, 2026
Lqp1 added a commit to Lqp1/nixpkgs that referenced this pull request Jan 15, 2026
github-merge-queue Bot pushed a commit to NixOS/nixpkgs that referenced this pull request Jan 28, 2026
Gigahawk pushed a commit to Gigahawk/nixpkgs that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants