Skip to content

Commit 6414924

Browse files
authored
feat: Add flexible commandArgs support for complete Feast CLI control (#5678)
* feat: Add flexible commandArgs support for complete Feast CLI control Signed-off-by: Blake <blaketastic2@gmail.com> * missed trailing pipe Signed-off-by: Blake <blaketastic2@gmail.com> --------- Signed-off-by: Blake <blaketastic2@gmail.com>
1 parent 1d640b6 commit 6414924

3 files changed

Lines changed: 24 additions & 0 deletions

File tree

infra/charts/feast-feature-server/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
3535
| Key | Type | Default | Description |
3636
|-----|------|---------|-------------|
3737
| affinity | object | `{}` | |
38+
| commandArgs | list | `[]` | Override the default command arguments for complete control over CLI options |
3839
| extraEnvs | list | `[]` | Additional environment variables to be set in the container |
3940
| feast_mode | string | `"online"` | Feast supported deployment modes - online (default), offline, ui and registry |
4041
| feature_store_yaml_base64 | string | `""` | [required] a base64 encoded version of feature_store.yaml |

infra/charts/feast-feature-server/templates/deployment.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ spec:
4747
{{- toYaml . | nindent 12 }}
4848
{{- end}}
4949
command:
50+
{{- if .Values.commandArgs }}
51+
{{- toYaml .Values.commandArgs | nindent 12 }}
52+
{{- else }}
53+
{{- /* Fallback to legacy behavior for backward compatibility */}}
5054
{{- if eq .Values.feast_mode "offline" }}
5155
- "feast"
5256
- "--log-level"
@@ -82,6 +86,7 @@ spec:
8286
- "0.0.0.0"
8387
{{- end }}
8488
{{- end }}
89+
{{- end }}
8590
ports:
8691
- name: {{ .Values.feast_mode }}
8792
{{- if eq .Values.feast_mode "offline" }}

infra/charts/feast-feature-server/values.yaml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,24 @@ feature_store_yaml_base64: ""
2929
# feast_mode -- Feast supported deployment modes - online (default), offline, ui and registry
3030
feast_mode: "online"
3131

32+
# commandArgs -- Override the default command arguments for complete control over CLI options
33+
# If not specified, falls back to legacy behavior based on feast_mode
34+
# Example for UI mode with custom options:
35+
# commandArgs:
36+
# - "feast"
37+
# - "--log-level"
38+
# - "INFO"
39+
# - "ui"
40+
# - "--root_path"
41+
# - "/feast"
42+
# - "--registry_ttl_sec"
43+
# - "300"
44+
# - "-h"
45+
# - "0.0.0.0"
46+
# - "-p"
47+
# - "8888"
48+
commandArgs: []
49+
3250
podAnnotations: {}
3351

3452
podSecurityContext: {}

0 commit comments

Comments
 (0)