fix: Filter empty SQL commands at call sites instead of silently ignoring in execute_snowflake_statement

Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>

Author: jials

sdk/python/feast/infra/registry/snowflake.py

@@ -139,8 +139,9 @@ def __init__(
         with GetSnowflakeConnection(self.registry_config) as conn:
             sql_function_file = f"{os.path.dirname(feast.__file__)}/infra/utils/snowflake/registry/snowflake_table_creation.sql"
             with open(sql_function_file, "r") as file:
-                sql_file = file.read()
-                sql_cmds = sql_file.split(";")
+                sql_cmds = [
+                    cmd.strip() for cmd in file.read().split(";") if cmd.strip()
+                ]
                 for command in sql_cmds:
                     query = command.replace("REGISTRY_PATH", f"{self.registry_path}")
                     execute_snowflake_statement(conn, query)
@@ -224,9 +225,10 @@ def teardown(self):
         with GetSnowflakeConnection(self.registry_config) as conn:
             sql_function_file = f"{os.path.dirname(feast.__file__)}/infra/utils/snowflake/registry/snowflake_table_deletion.sql"
             with open(sql_function_file, "r") as file:
-                sqlFile = file.read()
-                sqlCommands = sqlFile.split(";")
-                for command in sqlCommands:
+                sql_cmds = [
+                    cmd.strip() for cmd in file.read().split(";") if cmd.strip()
+                ]
+                for command in sql_cmds:
                     query = command.replace("REGISTRY_PATH", f"{self.registry_path}")
                     execute_snowflake_statement(conn, query)
 

sdk/python/feast/infra/utils/snowflake/snowflake_utils.py

@@ -123,8 +123,6 @@ def assert_snowflake_feature_names(feature_view: FeatureView) -> None:
 
 
 def execute_snowflake_statement(conn: SnowflakeConnection, query) -> SnowflakeCursor:
-    if not query.strip():
-        return conn.cursor()
     cursor = conn.cursor().execute(query)
     if cursor is None:
         raise SnowflakeQueryUnknownError(query)

sdk/python/tests/unit/infra/utils/snowflake/test_snowflake_utils.py

@@ -76,27 +76,17 @@ def test_parse_private_key_path_key_path_encrypted(encrypted_private_key):
 
 
 class TestExecuteSnowflakeStatement:
-    def test_empty_query_returns_cursor_without_executing(self):
+    def test_empty_query_is_passed_through_to_execute(self):
         mock_conn = MagicMock()
         mock_cursor = MagicMock()
+        mock_executed_cursor = MagicMock()
         mock_conn.cursor.return_value = mock_cursor
+        mock_cursor.execute.return_value = mock_executed_cursor
 
         result = execute_snowflake_statement(mock_conn, "")
 
-        assert result is mock_cursor
-        mock_conn.cursor.assert_called_once()
-        mock_cursor.execute.assert_not_called()
-
-    def test_whitespace_only_query_returns_cursor_without_executing(self):
-        mock_conn = MagicMock()
-        mock_cursor = MagicMock()
-        mock_conn.cursor.return_value = mock_cursor
-
-        result = execute_snowflake_statement(mock_conn, "   \t\n  ")
-
-        assert result is mock_cursor
-        mock_conn.cursor.assert_called_once()
-        mock_cursor.execute.assert_not_called()
+        assert result is mock_executed_cursor
+        mock_cursor.execute.assert_called_once_with("")
 
     def test_valid_query_executes_and_returns_cursor(self):
         mock_conn = MagicMock()