Skip to content

Commit 07607de

Browse files
fix(header): remove site-button inheritance from GitHub aux icon to correct boxed layout
1 parent 38db4d2 commit 07607de

2 files changed

Lines changed: 23 additions & 6 deletions

File tree

_includes/components/aux_nav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{% for link in site.aux_links %}
44
{% assign is_github_link = link.last contains "github.com" %}
55
<li class="aux-nav-list-item">
6-
<a href="{{ link.last }}" class="site-button{% if is_github_link %} feast-aux-link--icon feast-aux-link--github{% endif %}"
6+
<a href="{{ link.last }}" class="feast-aux-link{% if is_github_link %} feast-aux-link--icon feast-aux-link--github{% endif %}"
77
{% if site.aux_links_new_tab %}
88
target="_blank" rel="noopener noreferrer"
99
{% endif %}

_sass/custom/custom.scss

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,35 @@
1717
}
1818

1919
.feast-aux-nav {
20+
display: flex;
21+
align-items: center;
22+
height: auto;
23+
overflow: visible;
2024
margin-left: 0.35rem;
2125
padding-left: 0.6rem;
26+
padding-right: 0;
2227
border-left: 1px solid rgba($body-text-color, 0.2);
2328
}
2429

2530
.feast-aux-nav .aux-nav-list {
2631
display: flex;
2732
align-items: center;
33+
height: auto;
2834
gap: 0;
2935
}
3036

31-
.feast-aux-link--icon.site-button {
37+
.feast-aux-nav .aux-nav-list-item {
38+
display: flex;
39+
align-items: center;
40+
height: auto;
41+
}
42+
43+
.feast-aux-link {
44+
color: $link-color;
45+
text-decoration: none;
46+
}
47+
48+
.feast-aux-link--icon {
3249
width: 2rem;
3350
height: 2rem;
3451
min-width: 2rem;
@@ -38,18 +55,18 @@
3855
display: inline-flex;
3956
align-items: center;
4057
justify-content: center;
41-
color: transparent;
58+
color: inherit;
4259
border: 1px solid transparent;
4360
background-color: transparent;
4461
box-shadow: none;
4562
}
4663

47-
.feast-aux-link--icon.site-button:hover {
64+
.feast-aux-link--icon:hover {
4865
background-color: rgba($link-color, 0.1);
4966
border-color: rgba($link-color, 0.25);
5067
}
5168

52-
.feast-aux-link--icon.site-button:focus-visible {
69+
.feast-aux-link--icon:focus-visible {
5370
outline: 0;
5471
box-shadow: 0 0 0 3px rgba($link-color, 0.3);
5572
}
@@ -61,7 +78,7 @@
6178
display: block;
6279
}
6380

64-
.feast-aux-link--icon.site-button:hover .feast-aux-link__icon {
81+
.feast-aux-link--icon:hover .feast-aux-link__icon {
6582
fill: $body-heading-color;
6683
}
6784

0 commit comments

Comments
 (0)