bug: identify not work when only customized properties changed

Use serialized user as the storage key

Author: cosmos-explorer

examples/web-app/umd/featbit-js-client-sdk-4.2.4.js.map

@@ -1,6 +1,6 @@
 {
   "name": "@featbit/js-client-sdk",
-  "version": "4.2.4",
+  "version": "4.2.5",
   "description": "https://github.com/featbit/featbit-js-client-sdk",
   "main": "./dist/esm/index.js",
   "module": "./dist/esm/index.js",

…b-app/umd/featbit-js-client-sdk-4.2.4.js …b-app/umd/featbit-js-client-sdk-4.2.5.jsexamples/web-app/umd/featbit-js-client-sdk-4.2.4.js renamed to examples/web-app/umd/featbit-js-client-sdk-4.2.5.js examples/web-app/umd/featbit-js-client-sdk-4.2.4.js renamed to examples/web-app/umd/featbit-js-client-sdk-4.2.5.js

@@ -5,7 +5,7 @@ import {
 import { IOptions } from "../../options/IOptions";
 import { BaseStore } from "../../store/BaseStore";
 import { ILogger } from "../../logging";
-import { serializeUser } from "../../utils/serializeUser";
+import { hashSerializeUser, serializeUser } from "../../utils/serializeUser";
 
 export default class LocalStorageStore extends BaseStore {
   private logger: ILogger;
@@ -31,12 +31,14 @@ export default class LocalStorageStore extends BaseStore {
   }
 
   protected override async dumpStoreToStorage() {
-    const storageKey = `${StoreStorageKey}-${this._user.keyId}`;
+    const userHash = await hashSerializeUser(this._user);
+    const storageKey = `${StoreStorageKey}-${userHash}`;
     localStorage.setItem(storageKey, JSON.stringify(this.store));
   }
 
   protected override async loadStoreFromStorage() {
-    const storageKey = `${StoreStorageKey}-${this._user.keyId}`;
+    const userHash = await hashSerializeUser(this._user);
+    const storageKey = `${StoreStorageKey}-${userHash}`;
     const dataStoreStr = localStorage.getItem(storageKey);
     let store: IStoreDataStorage | null = null;
 

examples/web-app/umd/featbit-js-client-sdk-4.2.5.js.map

@@ -3,6 +3,7 @@ import {
   IStoreDataStorage
 } from "./store";
 import { BaseStore } from "./BaseStore";
+import { hashSerializeUser } from "../utils";
 
 export default class InMemoryStore extends BaseStore {
   private allStores: { [DataStoreStorageKey: string]: IStoreDataStorage } = {};
@@ -25,12 +26,14 @@ export default class InMemoryStore extends BaseStore {
   }
 
   protected override async dumpStoreToStorage() {
-    const storageKey = `${StoreStorageKey}-${this._user.keyId}`;
+    const userHash = await hashSerializeUser(this._user);
+    const storageKey = `${StoreStorageKey}-${userHash}`;
     this.allStores[storageKey] = {...this.store};
   }
 
   protected override async loadStoreFromStorage() {
-    const storageKey = `${StoreStorageKey}-${this._user.keyId}`;
+    const userHash = await hashSerializeUser(this._user);
+    const storageKey = `${StoreStorageKey}-${userHash}`;
 
     this.store = this.allStores[storageKey] ?? { flags: {}, version: 0 };
   }

examples/web-app/umd/featbit-js-client-sdk.js

@@ -5,7 +5,7 @@ export function serializeUser(user: IUser | undefined): string {
     return '';
   }
 
-  const builtInProperties = `${user.keyId},${user.name}`;
+  const builtInProperties = `${user.keyId},${user.name ?? ''}`;
 
   const customizedProperties = user.customizedProperties
     ?.sort((a, b) => {
@@ -25,4 +25,23 @@ export function serializeUser(user: IUser | undefined): string {
     .join(',');
 
   return `${builtInProperties},${customizedProperties}`;
-}
+}
+
+export async function hashSerializeUser(
+  user: IUser | undefined
+): Promise<string> {
+  const serialized = serializeUser(user);
+
+  if (!serialized) {
+    return '';
+  }
+
+  const encoder = new TextEncoder();
+  const data = encoder.encode(serialized);
+
+  const hashBuffer = await crypto.subtle.digest('SHA-256', data);
+
+  return Array.from(new Uint8Array(hashBuffer))
+  .map(b => b.toString(16).padStart(2, '0'))
+  .join('');
+}

examples/web-app/umd/featbit-js-client-sdk.js.map

@@ -1 +1 @@
-export const version = "4.2.4"; export const name = "@featbit/js-client-sdk";
+export const version = "4.2.5"; export const name = "@featbit/js-client-sdk";