Skip to content

Commit e75d715

Browse files
committed
Remove the "loadcerts" span
The actual load happens at request time, so instrumenting here is useless and gives a 0ms span.
1 parent 785da20 commit e75d715

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

internal/awsconfig/awsconfig.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,8 @@ import (
1616
"github.com/aws/aws-sdk-go-v2/aws/retry"
1717
"github.com/aws/aws-sdk-go-v2/config"
1818
"go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws"
19-
"go.opentelemetry.io/otel"
2019
)
2120

22-
var tracer = otel.Tracer("github.com/featherbread/randomizer/internal/awsconfig")
23-
2421
const (
2522
// DefaultTimeout is set to half of the 3-second response time limit that
2623
// Slack imposes on slash commands.
@@ -43,11 +40,7 @@ func New(ctx context.Context) (aws.Config, error) {
4340
// start latency (see [getEmbeddedCertTransport]). It can be enabled for
4441
// standard server deployments if desired, but is far less beneficial.
4542
if os.Getenv("AWS_CLIENT_EMBEDDED_TLS_ROOTS") == "1" {
46-
func() {
47-
_, span := tracer.Start(ctx, "loadcerts")
48-
defer span.End()
49-
transport = getEmbeddedCertTransport()
50-
}()
43+
transport = getEmbeddedCertTransport()
5144
}
5245

5346
cfg, err := config.LoadDefaultConfig(ctx,

0 commit comments

Comments
 (0)