Use "should" phrasing in Option::expect

featherbread · featherbread · commit 3a1d8e5d8b27 · 2026-01-24T15:16:37.000-08:00
One last detail I noticed while writing that big merge message.
diff --git a/src/transcode/stream.rs b/src/transcode/stream.rs
@@ -194,7 +194,7 @@ impl<P, E> Exchange<P, E> {
 	fn take_parent(&self) -> P {
 		self.parent
 			.take()
-			.expect("parent already taken from exchange")
+			.expect("Exchange should have its parent taken exactly once")
 	}
 
 	/// Stores an error for extraction by a parent, along with its source.

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ impl<P, E> Exchange<P, E> {`
`194`	`194`	`fn take_parent(&self) -> P {`
`195`	`195`	`self.parent`
`196`	`196`	`.take()`
`197`		`- .expect("parent already taken from exchange")`
	`197`	`+ .expect("Exchange should have its parent taken exactly once")`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`/// Stores an error for extraction by a parent, along with its source.`