WIP: Maintenance config#1285
Open
alex-deng-featurehub wants to merge 9 commits into
Open
Conversation
rvowles
reviewed
Apr 11, 2026
|
|
||
| When('I call the initialize endpoint', async function () { | ||
| const world = this as SdkWorld; | ||
| const setupApi = new SetupServiceApi(world.adminApiConfig); |
Contributor
There was a problem hiding this comment.
this needs to be in the world.ts, no API setup objects are done outside of that, so tell it to move it.
rvowles
reviewed
Apr 11, 2026
rvowles
reviewed
Apr 11, 2026
rvowles
reviewed
Apr 11, 2026
| description: "Identified but no permission" | ||
| 500: | ||
| description: "Unknown error" | ||
| /mr-api/maintenance-banner: |
Contributor
There was a problem hiding this comment.
i would prefer this to be /mr-api/system-config/maintenance-banner its a bit odd to see it at the top level namespace.
rvowles
reviewed
Apr 11, 2026
alex-deng-featurehub
force-pushed
the
maintenance-config
branch
2 times, most recently
from
7fca20f to
a9c1a2c
Compare
Adds maintenance.active (bool) and maintenance.message (string) as system config keys. When active, the MaintenanceInfo is returned on the unauthenticated /mr-api/initialize endpoint so the frontend can display a banner before login.
alex-deng-featurehub
force-pushed
the
maintenance-config
branch
from
a9c1a2c to
4bfd994
Compare
Display the maintenance banner when we have upcoming maintenance. Prevent logins and log you out whilst the maintenance window is active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: