fixing group editing to show superusers cannot be removed from the portfolio admin group#1301
Merged
Conversation
rvowles
force-pushed
the
permission-issues
branch
from
1eeef13 to
4e91023
Compare
Contributor
Author
|
/e2e-build |
2 similar comments
Contributor
Author
|
/e2e-build |
Contributor
Author
|
/e2e-build |
There is no indication from the groups API that a user is a superuser in a group and is therefore not deletable. Further the standard group API returns unnecessary member information.
rvowles
force-pushed
the
permission-issues
branch
from
e8b70a1 to
4d302cb
Compare
rvowles
changed the title
Contributor
Author
|
/e2e-build |
1 similar comment
Contributor
Author
|
/e2e-build |
Contributor
Author
|
/e2e-build |
Contributor
Author
|
/e2e-build |
Contributor
Author
|
/e2e-build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
APIs have been updated to force changes in how group management works to signal superusers who cannot be removed from portfolio (admin) groups.