fix: Add Semver conditions proper error handling

Author: Greg0

src/Datafile/Conditions/SemverEqualsCondition.php

@@ -13,15 +13,12 @@ final class SemverEqualsCondition implements ConditionInterface
     use ContextLookup;
 
     private string $attribute;
-    private Semver $value;
+    private string $value;
 
-    /**
-     * @throws InvalidArgumentException
-     */
     public function __construct(string $attribute, string $value)
     {
         $this->attribute = $attribute;
-        $this->value = new Semver($value);
+        $this->value = $value;
     }
 
     public function isSatisfiedBy(array $context): bool
@@ -32,9 +29,13 @@ public function isSatisfiedBy(array $context): bool
         }
         $comparator = new VersionComparator();
 
-        return $comparator(
-            new Semver($valueFromContext),
-            $this->value
-        ) === 0;
+        try {
+            return $comparator(
+                    new Semver($valueFromContext),
+                    new Semver($this->value)
+                ) === 0;
+        } catch (InvalidArgumentException $e) {
+            return false;
+        }
     }
 }

src/Datafile/Conditions/SemverGreaterThanCondition.php

@@ -13,15 +13,12 @@ final class SemverGreaterThanCondition implements ConditionInterface
     use ContextLookup, CompositeCondition;
 
     private string $attribute;
-    private Semver $value;
+    private string $value;
 
-    /**
-     * @throws InvalidArgumentException
-     */
     public function __construct(string $attribute, string $value)
     {
         $this->attribute = $attribute;
-        $this->value = new Semver($value);
+        $this->value = $value;
     }
 
     public function isSatisfiedBy(array $context): bool
@@ -32,9 +29,13 @@ public function isSatisfiedBy(array $context): bool
         }
         $comparator = new VersionComparator();
 
-        return $comparator(
-            new Semver($valueFromContext),
-            $this->value
-        ) === 1;
+        try {
+            return $comparator(
+                    new Semver($valueFromContext),
+                    new Semver($this->value)
+                ) === 1;
+        } catch (InvalidArgumentException $e) {
+            return false;
+        }
     }
 }

src/Datafile/Conditions/SemverLessThanCondition.php

@@ -13,15 +13,15 @@ final class SemverLessThanCondition implements ConditionInterface
     use ContextLookup, CompositeCondition;
 
     private string $attribute;
-    private Semver $value;
+    private string $value;
 
     /**
      * @throws InvalidArgumentException
      */
     public function __construct(string $attribute, string $value)
     {
         $this->attribute = $attribute;
-        $this->value = new Semver($value);
+        $this->value = $value;
     }
 
     public function isSatisfiedBy(array $context): bool
@@ -32,9 +32,13 @@ public function isSatisfiedBy(array $context): bool
         }
         $comparator = new VersionComparator();
 
-        return $comparator(
-            new Semver($valueFromContext),
-            $this->value
-        ) === -1;
+        try {
+            return $comparator(
+                    new Semver($valueFromContext),
+                    new Semver($this->value)
+                ) === -1;
+        } catch (InvalidArgumentException $e) {
+            return false;
+        }
     }
 }