fix(test): address code review findings

- Add wait_for_block_sync for CLN to prevent startup race conditions
- Re-ignore CLN keysend: upstream LDK fix needed (payment_secret in
  keysend HTLCs)
- Re-ignore Eclair splice: CI confirmed SplicePending timeout, likely
  LDK↔Eclair protocol mismatch
- Keep Eclair keysend un-ignored: CI confirmed it passes with latest
  Eclair image

Author: febyeji

tests/common/cln.rs

@@ -118,6 +118,23 @@ impl ExternalNode for TestClnNode {
 		Ok(info.blockheight as u64)
 	}
 
+	async fn wait_for_block_sync(&self, min_height: u64) -> Result<(), TestFailure> {
+		for i in 0..30 {
+			let height = self.get_block_height().await?;
+			if height >= min_height {
+				return Ok(());
+			}
+			if i == 29 {
+				return Err(self.make_error(format!(
+					"CLN did not reach height {} (at {}) after 60s",
+					min_height, height
+				)));
+			}
+			tokio::time::sleep(std::time::Duration::from_secs(2)).await;
+		}
+		Ok(())
+	}
+
 	async fn connect_peer(
 		&self, peer_id: PublicKey, addr: SocketAddress,
 	) -> Result<(), TestFailure> {

tests/integration_tests_cln.rs

@@ -76,7 +76,7 @@ async fn test_cln_receive_payments() {
 /// Upstream LDK fix needed: skip payment_secret verification when a valid
 /// `keysend_preimage` TLV is present.
 #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
-
+#[ignore = "CLN v24.08+ sends payment_secret in keysend — LDK rejects (upstream LDK fix needed)"]
 async fn test_cln_receive_keysend() {
 	let (bitcoind, electrs, cln) = setup_clients().await;
 	let node = setup_ldk_node();

tests/integration_tests_eclair.rs

@@ -113,10 +113,10 @@ async fn test_eclair_send_keysend() {
 	node.stop().unwrap();
 }
 
-/// Splicing was introduced in Eclair v0.10.0+. Our Docker image uses
-/// v0.14-SNAPSHOT which should support it; un-ignore once confirmed.
+/// CI confirmed: Eclair splice_in times out waiting for SplicePending event.
+/// LDK↔Eclair splice negotiation does not complete (likely protocol mismatch).
 #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
-
+#[ignore = "LDK↔Eclair splice negotiation times out (SplicePending not received)"]
 async fn test_eclair_splice() {
 	let (bitcoind, electrs, eclair) = setup_clients().await;
 	let node = setup_ldk_node();
@@ -131,7 +131,7 @@ async fn test_eclair_splice() {
 }
 
 #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
-
+#[ignore = "LDK↔Eclair splice negotiation times out (SplicePending not received)"]
 async fn test_eclair_splice_then_payment() {
 	let (bitcoind, electrs, eclair) = setup_clients().await;
 	let node = setup_ldk_node();