fix(oci): complete casing audit for OCI field transformations

Fix remaining casing issues found during systematic audit:

- V1 tools: uppercase type field (same fix as V2)
- tool_calls in messages: uppercase type when sending tool results back
  in multi-turn conversations
- Response tool_calls: lowercase type from OCI's "FUNCTION" back to
  "function" for Cohere SDK compatibility
- safety_mode: uppercase defensively (CONTEXTUAL/STRICT/OFF)

Integration tests added for each:
- test_chat_tool_use_response_type_lowered: verifies tool_call.type
  is "function" (not "FUNCTION") in responses
- test_chat_multi_turn_tool_use_v2: full tool use round-trip (call →
  result → final response)
- test_chat_safety_mode_v2: verifies safety_mode works on OCI

Author: fede-kamel

src/cohere/oci_client.py

@@ -728,7 +728,13 @@ def transform_request_to_oci(
                     oci_msg["content"] = msg.get("content") or []
 
                 if "tool_calls" in msg:
-                    oci_msg["toolCalls"] = msg["tool_calls"]
+                    oci_tool_calls = []
+                    for tc in msg["tool_calls"]:
+                        oci_tc = {**tc}
+                        if "type" in oci_tc:
+                            oci_tc["type"] = oci_tc["type"].upper()
+                        oci_tool_calls.append(oci_tc)
+                    oci_msg["toolCalls"] = oci_tool_calls
                 if "tool_call_id" in msg:
                     oci_msg["toolCallId"] = msg["tool_call_id"]
                 if "tool_plan" in msg:
@@ -772,7 +778,7 @@ def transform_request_to_oci(
             if "response_format" in cohere_body:
                 chat_request["responseFormat"] = cohere_body["response_format"]
             if "safety_mode" in cohere_body:
-                chat_request["safetyMode"] = cohere_body["safety_mode"]
+                chat_request["safetyMode"] = cohere_body["safety_mode"].upper()
             if "logprobs" in cohere_body:
                 chat_request["logprobs"] = cohere_body["logprobs"]
             if "tool_choice" in cohere_body:
@@ -816,13 +822,19 @@ def transform_request_to_oci(
             if "documents" in cohere_body:
                 chat_request["documents"] = cohere_body["documents"]
             if "tools" in cohere_body:
-                chat_request["tools"] = cohere_body["tools"]
+                oci_tools = []
+                for tool in cohere_body["tools"]:
+                    oci_tool = {**tool}
+                    if "type" in oci_tool:
+                        oci_tool["type"] = oci_tool["type"].upper()
+                    oci_tools.append(oci_tool)
+                chat_request["tools"] = oci_tools
             if "tool_results" in cohere_body:
                 chat_request["toolResults"] = cohere_body["tool_results"]
             if "response_format" in cohere_body:
                 chat_request["responseFormat"] = cohere_body["response_format"]
             if "safety_mode" in cohere_body:
-                chat_request["safetyMode"] = cohere_body["safety_mode"]
+                chat_request["safetyMode"] = cohere_body["safety_mode"].upper()
             if "priority" in cohere_body:
                 chat_request["priority"] = cohere_body["priority"]
 
@@ -917,7 +929,12 @@ def transform_oci_response_to_cohere(
                 message = {**message, "content": transformed_content}
 
             if "toolCalls" in message:
-                tool_calls = message["toolCalls"]
+                tool_calls = []
+                for tc in message["toolCalls"]:
+                    lowered_tc = {**tc}
+                    if "type" in lowered_tc:
+                        lowered_tc["type"] = lowered_tc["type"].lower()
+                    tool_calls.append(lowered_tc)
                 message = {k: v for k, v in message.items() if k != "toolCalls"}
                 message["tool_calls"] = tool_calls
             if "toolPlan" in message:

tests/test_oci_client.py

@@ -215,6 +215,105 @@ def test_chat_tool_use_v2(self):
         self.assertEqual(tool_call.function.name, "get_weather")
         self.assertIn("Toronto", tool_call.function.arguments)
 
+    def test_chat_tool_use_response_type_lowered(self):
+        """Test that tool_call type is lowercased in response (OCI returns FUNCTION)."""
+        response = self.client.chat(
+            model="command-a-03-2025",
+            messages=[{"role": "user", "content": "What's the weather in Toronto?"}],
+            max_tokens=200,
+            tools=[{
+                "type": "function",
+                "function": {
+                    "name": "get_weather",
+                    "description": "Get current weather for a location",
+                    "parameters": {
+                        "type": "object",
+                        "properties": {
+                            "location": {"type": "string", "description": "City name"}
+                        },
+                        "required": ["location"],
+                    },
+                },
+            }],
+        )
+
+        self.assertEqual(response.finish_reason, "TOOL_CALL")
+        tool_call = response.message.tool_calls[0]
+        # OCI returns "FUNCTION" — SDK must lowercase to "function" for Cohere compat
+        self.assertEqual(tool_call.type, "function")
+
+    def test_chat_multi_turn_tool_use_v2(self):
+        """Test multi-turn tool use: send tool result back after tool call."""
+        # Step 1: Get a tool call
+        response = self.client.chat(
+            model="command-a-03-2025",
+            messages=[{"role": "user", "content": "What's the weather in Toronto?"}],
+            max_tokens=200,
+            tools=[{
+                "type": "function",
+                "function": {
+                    "name": "get_weather",
+                    "description": "Get current weather for a location",
+                    "parameters": {
+                        "type": "object",
+                        "properties": {
+                            "location": {"type": "string", "description": "City name"}
+                        },
+                        "required": ["location"],
+                    },
+                },
+            }],
+        )
+        self.assertEqual(response.finish_reason, "TOOL_CALL")
+        tool_call = response.message.tool_calls[0]
+
+        # Step 2: Send tool result back
+        response2 = self.client.chat(
+            model="command-a-03-2025",
+            messages=[
+                {"role": "user", "content": "What's the weather in Toronto?"},
+                {
+                    "role": "assistant",
+                    "tool_calls": [{"id": tool_call.id, "type": "function", "function": {"name": "get_weather", "arguments": tool_call.function.arguments}}],
+                    "tool_plan": response.message.tool_plan,
+                },
+                {
+                    "role": "tool",
+                    "tool_call_id": tool_call.id,
+                    "content": [{"type": "text", "text": "15°C, sunny"}],
+                },
+            ],
+            max_tokens=200,
+            tools=[{
+                "type": "function",
+                "function": {
+                    "name": "get_weather",
+                    "description": "Get current weather for a location",
+                    "parameters": {
+                        "type": "object",
+                        "properties": {
+                            "location": {"type": "string", "description": "City name"}
+                        },
+                        "required": ["location"],
+                    },
+                },
+            }],
+        )
+
+        self.assertIsNotNone(response2.message)
+        # Model should respond with text incorporating the tool result
+        self.assertTrue(len(response2.message.content) > 0)
+
+    def test_chat_safety_mode_v2(self):
+        """Test that safety_mode is uppercased for OCI."""
+        # Cohere SDK enum values are already uppercase, but test lowercase too
+        response = self.client.chat(
+            model="command-a-03-2025",
+            messages=[{"role": "user", "content": "Say hi"}],
+            safety_mode="STRICT",
+        )
+        self.assertIsNotNone(response.message)
+
     def test_chat_stream_v2(self):
         """Test streaming chat with v2 client."""
         events = []