Skip to content

Force auth when fetching Kafka metadata#707

Open
andrei-ionescu wants to merge 1 commit into
fede1024:masterfrom
andrei-ionescu:ai.force_cred_retrieval
Open

Force auth when fetching Kafka metadata#707
andrei-ionescu wants to merge 1 commit into
fede1024:masterfrom
andrei-ionescu:ai.force_cred_retrieval

Conversation

@andrei-ionescu
Copy link
Copy Markdown
Contributor

Kafka metadata may also require authentication. This PR forces authentication before fetching Kafka metadata.

@andrei-ionescu
Copy link
Copy Markdown
Contributor Author

@fede1024, @benesch, @davidblewett Can some one have a look into this small change?

@andrei-ionescu andrei-ionescu force-pushed the ai.force_cred_retrieval branch from 779cd53 to e962c8c Compare December 10, 2024 16:04
@fede1024
Copy link
Copy Markdown
Owner

I'm not sure I understand this change. What happens to authentication if we fetch metadata without doing a poll first? Is there some librdkafka documentation that we can reference to?
Thank you

@andrei-ionescu
Copy link
Copy Markdown
Contributor Author

andrei-ionescu commented Nov 19, 2025

In the current code when fetching metadata information the authentication does not happen which means that the call for metadata is missing auth.

In some cases the metadata endpoint may also need authentication, in other cases the endpoint may be auth-free. Our Kafka deployment has auth for all endpoints.

This forces the poll for auth even for metadata calls.

I re-tested it, checking if this is still reproducible and, indeed, it is still reproducible. On my Kafka deployment that has authentication enabled on all endpoints it is needed to first go through the token fetch process.

This step of going through token fetching process before any call to any Kafka endpoint is needed.

@andrei-ionescu
Copy link
Copy Markdown
Contributor Author

@fede1024, @benesch, @davidblewett Can you have a look into this minor change? If this needs other things let me know.

@andrei-ionescu andrei-ionescu force-pushed the ai.force_cred_retrieval branch 4 times, most recently from 7c7f815 to 72ca456 Compare May 20, 2026 12:11
@andrei-ionescu andrei-ionescu force-pushed the ai.force_cred_retrieval branch from 72ca456 to 8d8a3d6 Compare May 20, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants