Add DescribeTopics and DescribeCluster support for admin client API#721
Open
alihan-synnada wants to merge 6 commits into
Open
Add DescribeTopics and DescribeCluster support for admin client API#721alihan-synnada wants to merge 6 commits into
alihan-synnada wants to merge 6 commits into
Conversation
alihan-synnada
commented
Sep 13, 2024
| let high_bits = unsafe { rdsys::rd_kafka_Uuid_most_significant_bits(topic_id) } as u64; | ||
| let low_bits = unsafe { rdsys::rd_kafka_Uuid_least_significant_bits(topic_id) } as u64; | ||
| Uuid::from_u64_pair(high_bits, low_bits) | ||
| } |
Author
There was a problem hiding this comment.
Is it really worth adding a dependency to the uuid crate when Uuid is only used here? We might as well remove the dependency and only return a (high_bits, low_bits) tuple.
Author
|
I added DescribeCluster support as well. DescribeConsumerGroups should also be relatively easier to implement since the some of the types it returns ( |
Author
|
I'm satisfied with the PR myself but there are a few points in my mind:
|
Author
|
@davidblewett @benesch Any opportunities to review and possibly merge within next week? |
|
Can someone please review and merge this feature? I've rebased it in my fork and seems to be working fine, but love to avoid using a git dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #614
Adding DescribeTopics
nowandalso potentiallyDescribeCluster in this PR as per #614I'll write the docs and tests, and then mark as ready for review