Fix Memory Leak in Client Initialization#834
Open
GeorgeBerdovskiy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
src/client.rs, the C functionrd_kafka_newis called with a pointer to aNativeClientConfigobject. According to a comment in the implementation ofrd_kafka_new, it takes ownership of the config on success. That means when the function fails, the caller is responsible for freeing it. See line 2445 ofsrc/rdkafka.cin thelibrdkafkarepository.By calling
ManuallyDrop::new(native_config), the Rust client initialization code prevents the compiler from dropping the config automatically. Otherwise, it would be dropped even thoughrd_kafka_newtook ownership of it, resulting in possible UAF bugs.Because of this, when
rd_kafka_newfails, the config isn't dropped, resulting in a memory leak. I confirmed this using a simple Rust program and Valgrind.Code
Command
Output
The fix is simple. If
rd_kafka_newfails (returns a null pointer), let Rust drop the config automatically. If it succeeds (does NOT return a null pointer),forgetthe config.Here's what Valgrind has to say for the same program using my fix.