Improve activity propagation to message authors

Send activities to the original message authors as well to ensure better federation

- Send Create, Announce, Undo, Update, and Delete activities to original message authors

- Ensure proper delivery of activities between interacting users

Author: dahlia

CHANGES.md

@@ -43,6 +43,18 @@ To be released.
 
  -  Added `SessionGetOutboxOptions` interface.
 
+ -  Activities are more precisely propagated.
+
+     -  The `Message.reply()` method now sends the `Create` activity to
+        the author of the original message as well.
+     -  The `Message.share()` method now sends the `Announce` activity to
+        the author of the original message as well.
+     -  The `AuthorizedSharedMessage.unshare()` method now sends the `Undo`
+        activity to the author of the original message as well.
+     -  The `AuthorizedMessage.update()` method now sends the `Update` activity
+        to the author of the original message as well if it is a reply.
+     -  The `AuthorizedMessage.delete()` method now sends the `Delete` activity
+        to the author of the original message as well if it is a reply.
 
 
 Version 0.1.1

src/message-impl.test.ts

@@ -270,14 +270,22 @@ Deno.test("MessageImpl.reply()", async () => {
   assertEquals(await repository.countMessages(), 1);
   const [create] = await Array.fromAsync(repository.getMessages());
   assert(create != null);
-  assertEquals(ctx.sentActivities.length, 1);
+  assertEquals(ctx.sentActivities.length, 2);
   const { recipients, activity } = ctx.sentActivities[0];
   assertEquals(recipients, "followers");
   assertInstanceOf(activity, Create);
   assertEquals(
     await activity.toJsonLd({ format: "compact" }),
     await create.toJsonLd({ format: "compact" }),
   );
+  const { recipients: recipients2, activity: activity2 } =
+    ctx.sentActivities[1];
+  assertEquals(recipients2, [originalMsg.actor]);
+  assertInstanceOf(activity2, Create);
+  assertEquals(
+    await activity2.toJsonLd({ format: "compact" }),
+    await create.toJsonLd({ format: "compact" }),
+  );
   assertEquals(
     await reply.raw.toJsonLd({ format: "compact" }),
     await (await create.getObject())?.toJsonLd({ format: "compact" }),
@@ -319,7 +327,7 @@ Deno.test("MessageImpl.share()", async (t) => {
     assertEquals(await repository.countMessages(), 1);
     const [announce] = await Array.fromAsync(repository.getMessages());
     assert(announce != null);
-    assertEquals(ctx.sentActivities.length, 1);
+    assertEquals(ctx.sentActivities.length, 2);
     const { recipients, activity } = ctx.sentActivities[0];
     assertEquals(recipients, "followers");
     assertInstanceOf(activity, Announce);
@@ -332,6 +340,19 @@ Deno.test("MessageImpl.share()", async (t) => {
       await activity.toJsonLd({ format: "compact" }),
       await announce.toJsonLd({ format: "compact" }),
     );
+    const { recipients: recipients2, activity: activity2 } =
+      ctx.sentActivities[1];
+    assertEquals(recipients2, [originalMsg.actor]);
+    assertInstanceOf(activity2, Announce);
+    assertEquals(activity2.toIds, [ctx.getFollowersUri(bot.identifier)]);
+    assertEquals(activity2.ccIds, [
+      PUBLIC_COLLECTION,
+      originalPost.attributionId,
+    ]);
+    assertEquals(
+      await activity2.toJsonLd({ format: "compact" }),
+      await announce.toJsonLd({ format: "compact" }),
+    );
     assertEquals(
       await sharedMsg.raw.toJsonLd({ format: "compact" }),
       await announce.toJsonLd({ format: "compact" }),
@@ -346,7 +367,7 @@ Deno.test("MessageImpl.share()", async (t) => {
   await t.step("unshare()", async () => {
     await sharedMsg.unshare();
     assertEquals(await repository.countMessages(), 0);
-    assertEquals(ctx.sentActivities.length, 1);
+    assertEquals(ctx.sentActivities.length, 2);
     const { recipients, activity } = ctx.sentActivities[0];
     assertEquals(recipients, "followers");
     assertInstanceOf(activity, Undo);
@@ -357,6 +378,17 @@ Deno.test("MessageImpl.share()", async (t) => {
       originalPost.attributionId,
     ]);
     assertEquals(activity.objectId, sharedMsg.id);
+    const { recipients: recipients2, activity: activity2 } =
+      ctx.sentActivities[1];
+    assertEquals(recipients2, [originalMsg.actor]);
+    assertInstanceOf(activity2, Undo);
+    assertEquals(activity2.actorId, ctx.getActorUri(bot.identifier));
+    assertEquals(activity2.toIds, [ctx.getFollowersUri(bot.identifier)]);
+    assertEquals(activity2.ccIds, [
+      PUBLIC_COLLECTION,
+      originalPost.attributionId,
+    ]);
+    assertEquals(activity2.objectId, sharedMsg.id);
   });
 });
 

src/message-impl.ts

@@ -182,6 +182,16 @@ export class MessageImpl<T extends MessageClass, TContextData>
         excludeBaseUris: [new URL(this.session.context.origin)],
       },
     );
+    await this.session.context.sendActivity(
+      this.session.bot,
+      this.actor,
+      announce,
+      {
+        preferSharedInbox: true,
+        excludeBaseUris: [new URL(this.session.context.origin)],
+        fanout: "skip",
+      },
+    );
     const actor = announce.actorId?.href === this.session.actorId.href
       ? await this.session.getActor()
       : await announce.getActor(this.session.context);
@@ -194,21 +204,32 @@ export class MessageImpl<T extends MessageClass, TContextData>
       original: this,
       unshare: async () => {
         await this.session.bot.repository.removeMessage(id);
+        const undo = new Undo({
+          id: new URL("#delete", uri),
+          actor: this.session.context.getActorUri(
+            this.session.bot.identifier,
+          ),
+          tos: announce.toIds,
+          ccs: announce.ccIds,
+          object: announce,
+        });
         await this.session.context.sendActivity(
           this.session.bot,
           "followers",
-          new Undo({
-            id: new URL("#delete", uri),
-            actor: this.session.context.getActorUri(
-              this.session.bot.identifier,
-            ),
-            tos: announce.toIds,
-            ccs: announce.ccIds,
-            object: announce,
-          }),
+          undo,
+          {
+            preferSharedInbox: true,
+            excludeBaseUris: [new URL(this.session.context.origin)],
+          },
+        );
+        await this.session.context.sendActivity(
+          this.session.bot,
+          this.actor,
+          undo,
           {
             preferSharedInbox: true,
             excludeBaseUris: [new URL(this.session.context.origin)],
+            fanout: "skip",
           },
         );
       },
@@ -474,6 +495,22 @@ export class AuthorizedMessageImpl<T extends MessageClass, TContextData>
       update,
       { preferSharedInbox, excludeBaseUris },
     );
+    if (this.replyTarget != null) {
+      await this.session.context.sendActivity(
+        this.session.bot,
+        this.replyTarget.actor,
+        update,
+        { preferSharedInbox: true, excludeBaseUris, fanout: "skip" },
+      );
+    }
+    if (this.quoteTarget != null) {
+      await this.session.context.sendActivity(
+        this.session.bot,
+        this.quoteTarget.actor,
+        update,
+        { preferSharedInbox: true, excludeBaseUris, fanout: "skip" },
+      );
+    }
   }
 
   async delete(): Promise<void> {
@@ -527,6 +564,22 @@ export class AuthorizedMessageImpl<T extends MessageClass, TContextData>
         { preferSharedInbox: true, excludeBaseUris },
       );
     }
+    if (this.replyTarget != null) {
+      await this.session.context.sendActivity(
+        this.session.bot,
+        this.replyTarget.actor,
+        activity,
+        { preferSharedInbox: true, excludeBaseUris, fanout: "skip" },
+      );
+    }
+    if (this.quoteTarget != null) {
+      await this.session.context.sendActivity(
+        this.session.bot,
+        this.quoteTarget.actor,
+        activity,
+        { preferSharedInbox: true, excludeBaseUris, fanout: "skip" },
+      );
+    }
   }
 }
 

src/session-impl.ts

@@ -316,12 +316,20 @@ export class SessionImpl<TContextData> implements Session<TContextData> {
         { preferSharedInbox, excludeBaseUris },
       );
     }
+    if (options.replyTarget != null) {
+      await this.context.sendActivity(
+        this.bot,
+        options.replyTarget.actor,
+        activity,
+        { preferSharedInbox, excludeBaseUris, fanout: "skip" },
+      );
+    }
     if (options.quoteTarget != null) {
       await this.context.sendActivity(
         this.bot,
         options.quoteTarget.actor,
         activity,
-        { preferSharedInbox, excludeBaseUris },
+        { preferSharedInbox, excludeBaseUris, fanout: "skip" },
       );
     }
     return await createMessage(