Skip to content

Commit 36ac23d

Browse files
committed
Fix neverBundle callback signature to match tsdown v0.22.0 API
The neverBundle callback's second parameter should be `parentId?: string` (optional) per tsdown/rolldown's ExternalOptionFunction type, not `importer: string | undefined` (required). While TypeScript's callback compatibility allows passing fewer parameters, aligning the name and optionality with the documented API makes the intent clearer and avoids any future type mismatch if the type is checked strictly. #766 (comment) Assisted-by: Claude Code:claude-sonnet-4-6
1 parent f243119 commit 36ac23d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/fedify/tsdown.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ export default [
4646
.map((f) => f.replace(sep, "/")),
4747
],
4848
deps: {
49-
neverBundle: (id: string, importer: string | undefined) => {
49+
neverBundle: (id: string, parentId?: string) => {
5050
if (id.startsWith("node:")) return true;
5151
if (id !== "@fedify/fixture") return;
52-
return !isTestingHelperImporter(importer);
52+
return !isTestingHelperImporter(parentId);
5353
},
5454
// Bundle @fedify/fixture back in for src/testing/ files (needed for
5555
// cfworkers), while keeping it external for test files so that

0 commit comments

Comments
 (0)