Skip to content

Commit 7ee6247

Browse files
committed
Improve get-reviews skill instructions and review template
- Note that plans/ is already gitignore'd to avoid redundant checks - Clarify wording in SKILL.md for drafting review files - Add WRONG judgement handling in review.md Plans section with guidance on addressing misunderstandings - Refine Comments section: discourage conversational fillers and personal pronouns, broaden language separation rule, add note to start with "Addressed in {COMMIT_HASH}." for related changes Assisted-by: Claude Code:claude-sonnet-4-6
1 parent fc96c7c commit 7ee6247

2 files changed

Lines changed: 20 additions & 4 deletions

File tree

.agents/skills/get-reviews/SKILL.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ Organize the reviews
7070

7171
After fetching the PR and its reviews, organize the reviews.
7272
[*plans* directory in the root](../../../plans/) is a good place to store them.
73+
*plans/* is already ignored in `.gitignore`, so don't check that it is ignored.
7374
7475
- *plans/{PR\_NUMBER}/index.md*: The main file for the PR.
7576
- The body of the PR
@@ -107,7 +108,7 @@ naming rules:
107108
the file so the context is preserved.
108109
109110
The format of review files should be as [review.md](./review.md).
110-
Read the reviews and fill the format as a draft with the related information.
111+
Read the review and draft the format based on the relevant information.
111112
The files should be written in the contributor's language. But the title of
112113
the item in the file (e.g., “Summary”, “Judgement”, “Plans”) should be in
113114
English for consistency.

.agents/skills/get-reviews/review.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,15 @@ Plans
7272
- If the review is judged as **PARTIAL**, what are the modifications to apply?
7373
- Why the plans can apply the review correctly?
7474
75+
If the review is judged as **WRONG**, write plans to why the reviewer
76+
misunderstood the code and how to prevent similar misunderstandings
77+
in the future.
78+
- What are the reasons for the misunderstanding?
79+
- How to prevent similar misunderstandings in the future?
80+
- Consider adding comments to the code, improving documentation,
81+
renaming variables or functions for clarity,
82+
or refactoring the code to make it more understandable.
83+
7584
If the review is judged as **NEEDS EVALUATION**,
7685
write the plans to evaluate the review, such as testing plans.
7786
- How to test or evaluate?
@@ -95,14 +104,20 @@ Comments
95104
<!--
96105
Prepare the response comments in advance after applying the review or
97106
judging the review as wrong. The comments should be polite and constructive.
107+
Do not use conversational fillers (e.g. "You're right.") Avoid using personal
108+
pronouns such as "I," "we," or "you." Focus on describing how the code has
109+
changed rather than stating "I did something."
98110
99-
If the contributor don't use English, separate this section into two parts,
111+
If there is a language that the contributor is more comfortable using than
112+
English, separate this section into two parts,
100113
- the language of the contributor using
101114
- English, ready to be posted as a response
102115
116+
Even if it's not what the review requested, if the related code has changed,
117+
start with: "Addressed in {COMMIT_HASH}."
118+
103119
If the review is judged as **CORRECT**, write comments to apply the review
104-
to explain how to apply the review and why it is correct. The comments to
105-
applied reviews should be started with "Addressed in {COMMIT_HASH}.".
120+
to explain how to apply the review.
106121
107122
If the review is judged as **WRONG**, write comments to dismiss the review
108123
to explain why the review is wrong and should be dismissed.

0 commit comments

Comments
 (0)