Skip to content

Commit 86a1f54

Browse files
committed
Polish inbox defaults and test wording
Extract the inbox actor fallback strings into shared constants so the config defaults stay aligned in one place. This also narrows the Deno Temporal regression test title to the exact 2.7.0 boundary case that it asserts, which keeps the test intent precise. Assisted-by: Codex:gpt-5.4
1 parent fd47b77 commit 86a1f54

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

packages/cli/src/inbox/command.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ import {
1313
import { configContext } from "../config.ts";
1414
import { createTunnelOption } from "../options.ts";
1515

16+
const DEFAULT_EPHEMERAL_INBOX_NAME = "Fedify Ephemeral Inbox";
17+
const DEFAULT_EPHEMERAL_INBOX_SUMMARY =
18+
"An ephemeral ActivityPub inbox for testing purposes.";
19+
1620
export const inboxCommand = command(
1721
"inbox",
1822
merge(
@@ -50,8 +54,9 @@ export const inboxCommand = command(
5054
}),
5155
{
5256
context: configContext,
53-
key: (config) => config.inbox?.actorName ?? "Fedify Ephemeral Inbox",
54-
default: "Fedify Ephemeral Inbox",
57+
key: (config) =>
58+
config.inbox?.actorName ?? DEFAULT_EPHEMERAL_INBOX_NAME,
59+
default: DEFAULT_EPHEMERAL_INBOX_NAME,
5560
},
5661
),
5762
actorSummary: bindConfig(
@@ -62,8 +67,8 @@ export const inboxCommand = command(
6267
context: configContext,
6368
key: (config) =>
6469
config.inbox?.actorSummary ??
65-
"An ephemeral ActivityPub inbox for testing purposes.",
66-
default: "An ephemeral ActivityPub inbox for testing purposes.",
70+
DEFAULT_EPHEMERAL_INBOX_SUMMARY,
71+
default: DEFAULT_EPHEMERAL_INBOX_SUMMARY,
6772
},
6873
),
6974
authorizedFetch: bindConfig(

packages/init/src/action/configs.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ function setDenoVersion(
7171
});
7272
}
7373

74-
test("loadDenoConfig omits unstable.temporal on Deno 2.7.0 and newer", () => {
74+
test("loadDenoConfig omits unstable.temporal on Deno 2.7.0", () => {
7575
const originalDeno = (globalThis as Record<string, unknown>).Deno;
7676
setDenoVersion({ deno: "2.7.0", v8: "0.0.0", typescript: "0.0.0" });
7777

0 commit comments

Comments
 (0)