Harden delivery metrics tests

Add fallback metadata for the federation meter and make the SDK metrics
test always release its meter provider and fetch mock, even when assertions
fail.

#755 (comment)
#755 (comment)

Assisted-by: gpt-5.5

Author: dahlia

packages/fedify/src/federation/metrics.ts

@@ -7,6 +7,9 @@ import {
 } from "@opentelemetry/api";
 import metadata from "../../deno.json" with { type: "json" };
 
+const meterName = metadata.name || "@fedify/fedify";
+const meterVersion = metadata.version || undefined;
+
 class FederationMetrics {
   readonly deliverySent: Counter;
   readonly deliveryPermanentFailure: Counter;
@@ -15,7 +18,7 @@ class FederationMetrics {
   readonly inboxProcessingDuration: Histogram;
 
   constructor(meterProvider: MeterProvider) {
-    const meter = meterProvider.getMeter(metadata.name, metadata.version);
+    const meter = meterProvider.getMeter(meterName, meterVersion);
     this.deliverySent = meter.createCounter("activitypub.delivery.sent", {
       description: "ActivityPub delivery attempts.",
       unit: "{attempt}",

packages/fedify/src/federation/send.test.ts

@@ -633,34 +633,39 @@ test("sendActivity() exports delivery metrics through OpenTelemetry SDK", async
   fetchMock.spyGlobal();
   fetchMock.post("https://sdk-metrics.example/inbox", { status: 202 });
 
-  await sendActivity({
-    activity: {
-      "@context": "https://www.w3.org/ns/activitystreams",
-      type: "Create",
-      id: "https://example.com/activity",
-      actor: "https://example.com/person",
-    },
-    activityId: "https://example.com/activity",
-    activityType: "https://www.w3.org/ns/activitystreams#Create",
-    keys: [],
-    inbox: new URL("https://sdk-metrics.example/inbox"),
-    meterProvider,
-  });
-
-  await meterProvider.forceFlush();
-  const exportedMetrics = exporter.getMetrics()
-    .flatMap((resourceMetrics) => resourceMetrics.scopeMetrics)
-    .flatMap((scopeMetrics) => scopeMetrics.metrics);
-  const sent = exportedMetrics.find((metric) =>
-    metric.descriptor.name === "activitypub.delivery.sent"
-  );
-  assert(sent != null);
-  assertEquals(sent.dataPoints.length, 1);
-  assertEquals(
-    sent.dataPoints[0].attributes["activitypub.remote.host"],
-    "sdk-metrics.example",
-  );
+  try {
+    await sendActivity({
+      activity: {
+        "@context": "https://www.w3.org/ns/activitystreams",
+        type: "Create",
+        id: "https://example.com/activity",
+        actor: "https://example.com/person",
+      },
+      activityId: "https://example.com/activity",
+      activityType: "https://www.w3.org/ns/activitystreams#Create",
+      keys: [],
+      inbox: new URL("https://sdk-metrics.example/inbox"),
+      meterProvider,
+    });
 
-  await meterProvider.shutdown();
-  fetchMock.hardReset();
+    await meterProvider.forceFlush();
+    const exportedMetrics = exporter.getMetrics()
+      .flatMap((resourceMetrics) => resourceMetrics.scopeMetrics)
+      .flatMap((scopeMetrics) => scopeMetrics.metrics);
+    const sent = exportedMetrics.find((metric) =>
+      metric.descriptor.name === "activitypub.delivery.sent"
+    );
+    assert(sent != null);
+    assertEquals(sent.dataPoints.length, 1);
+    assertEquals(
+      sent.dataPoints[0].attributes["activitypub.remote.host"],
+      "sdk-metrics.example",
+    );
+  } finally {
+    try {
+      await meterProvider.shutdown();
+    } finally {
+      fetchMock.hardReset();
+    }
+  }
 });