Handle Bun invalid URL errors

Treat Bun's ERR_INVALID_URL TypeErrors the same way as the Invalid URL
messages produced by Deno and Node when classifying malformed ActivityPub
IRI fields.  This keeps live inbox handling and queued inbox workers from
retrying permanently malformed payloads only on Bun.

Add a small regression test for the shared invalid URL TypeError helper so
future runtime message differences stay covered.

Author: dahlia

packages/fedify/src/federation/handler.ts

@@ -16,6 +16,7 @@ import {
   hasSignature,
   InvalidContextReferenceError,
   isClearlyMalformedContextReference,
+  isInvalidUrlTypeError,
   verifyCompactJsonLd,
   wrapContextLoaderForJsonLd,
 } from "../sig/ld.ts";
@@ -101,8 +102,9 @@ function isInvalidJsonLdError(error: unknown): error is Error {
 
 function isValidationTypeError(error: unknown): error is TypeError {
   return error instanceof TypeError &&
-    /^(Invalid JSON-LD:|Invalid type:|Unexpected type:|Invalid URL)/
-      .test(error.message);
+    (/^(Invalid JSON-LD:|Invalid type:|Unexpected type:)/
+      .test(error.message) ||
+      isInvalidUrlTypeError(error));
 }
 
 function isPermanentActivityParseError(error: unknown): error is Error {
@@ -115,8 +117,8 @@ function isPermanentActivityParseError(error: unknown): error is Error {
   // bucket.  jsonld.SyntaxError is similarly only permanent when it is local
   // to the payload rather than a remote-context loading failure.  Raw loader
   // TypeErrors for @context resolution are normalized earlier at the
-  // context-loading layer, so any remaining "Invalid URL ..." here comes from
-  // sender-controlled ActivityPub IRI fields and stays permanent.
+  // context-loading layer, so any remaining invalid-URL TypeError here comes
+  // from sender-controlled ActivityPub IRI fields and stays permanent.
   return isInvalidJsonLdError(error) || isValidationTypeError(error);
 }
 

packages/fedify/src/federation/middleware.ts

@@ -46,6 +46,7 @@ import {
   hasSignature,
   InvalidContextReferenceError,
   isClearlyMalformedContextReference,
+  isInvalidUrlTypeError,
   signJsonLd,
   wrapContextLoaderForJsonLd,
 } from "../sig/ld.ts";
@@ -157,8 +158,8 @@ function isPermanentInboxParseError(error: unknown): error is Error {
   // metadata URL failures.  jsonld.SyntaxError is similarly only permanent
   // when it is local to the payload rather than a remote-context loading
   // failure.  Raw loader TypeErrors for @context resolution are normalized
-  // earlier at the context-loading layer, so any remaining "Invalid URL ..."
-  // here comes from sender-controlled ActivityPub IRI fields and stays
+  // earlier at the context-loading layer, so any remaining invalid-URL
+  // TypeError here comes from sender-controlled ActivityPub IRI fields and stays
   // permanent instead of churning the retry queue.
   return (error instanceof Error &&
     (error.name === "UnsafeJsonLdError" ||
@@ -167,8 +168,9 @@ function isPermanentInboxParseError(error: unknown): error is Error {
       (error.name === "jsonld.SyntaxError" &&
         !isRemoteContextLoadingFailure(error)))) ||
     (error instanceof TypeError &&
-      /^(Invalid JSON-LD:|Invalid type:|Unexpected type:|Invalid URL)/
-        .test(error.message));
+      (/^(Invalid JSON-LD:|Invalid type:|Unexpected type:)/
+        .test(error.message) ||
+        isInvalidUrlTypeError(error)));
 }
 
 /**

packages/fedify/src/sig/ld.test.ts

@@ -21,13 +21,29 @@ import {
   compactJsonLd,
   createSignature,
   detachSignature,
+  isInvalidUrlTypeError,
   type Signature,
   signJsonLd,
   UnsafeJsonLdError,
   verifyJsonLd,
   verifySignature,
 } from "./ld.ts";
 
+test("isInvalidUrlTypeError()", () => {
+  assert(isInvalidUrlTypeError(new TypeError("Invalid URL: http://[")));
+  assert(
+    isInvalidUrlTypeError(
+      new TypeError('"http://[" cannot be parsed as a URL.'),
+    ),
+  );
+  const error = new TypeError("Failed to parse URL") as TypeError & {
+    code?: string;
+  };
+  error.code = "ERR_INVALID_URL";
+  assert(isInvalidUrlTypeError(error));
+  assertFalse(isInvalidUrlTypeError(new TypeError("Failed to fetch")));
+});
+
 test("attachSignature()", () => {
   const sig: Signature = {
     "@context": "https://w3id.org/identity/v1",

packages/fedify/src/sig/ld.ts

@@ -392,9 +392,13 @@ function normalizeContextReference(
   return URL.canParse(reference) ? new URL(reference).href : reference;
 }
 
-function isInvalidUrlTypeError(error: unknown): error is TypeError {
+/** @internal */
+export function isInvalidUrlTypeError(error: unknown): error is TypeError {
+  const code = (error as { code?: unknown }).code;
   return error instanceof TypeError &&
-    /^Invalid URL(?::|$)/.test(error.message);
+    (code === "ERR_INVALID_URL" ||
+      /^Invalid URL(?::|$)/.test(error.message) ||
+      / cannot be parsed as a URL\.?$/.test(error.message));
 }
 
 async function applyGraphAliasContext(