Skip to content

Commit e7249cc

Browse files
committed
Tighten telemetry review fixes
The fixture package now declares the OpenTelemetry API dependency that its public test metric helpers expose in their exported types. The federation metric instruments also use the package metadata directly, matching the surrounding tracing code. #755 (review) #755 (comment) Assisted-by: gpt-5.5
1 parent 7b2bf8b commit e7249cc

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

packages/fedify/src/federation/metrics.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ import {
77
} from "@opentelemetry/api";
88
import metadata from "../../deno.json" with { type: "json" };
99

10-
const meterName = metadata.name || "@fedify/fedify";
11-
const meterVersion = metadata.version || undefined;
12-
1310
class FederationMetrics {
1411
readonly deliverySent: Counter;
1512
readonly deliveryPermanentFailure: Counter;
@@ -18,7 +15,7 @@ class FederationMetrics {
1815
readonly inboxProcessingDuration: Histogram;
1916

2017
constructor(meterProvider: MeterProvider) {
21-
const meter = meterProvider.getMeter(meterName, meterVersion);
18+
const meter = meterProvider.getMeter(metadata.name, metadata.version);
2219
this.deliverySent = meter.createCounter("activitypub.delivery.sent", {
2320
description: "ActivityPub delivery attempts.",
2421
unit: "{attempt}",

packages/fixture/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"dependencies": {
3535
"@fedify/vocab-runtime": "workspace:^",
3636
"@logtape/logtape": "catalog:",
37+
"@opentelemetry/api": "catalog:",
3738
"@opentelemetry/core": "catalog:",
3839
"@opentelemetry/sdk-trace-base": "catalog:"
3940
},

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)