Merge pull request #556 from moreal/validate-workspace-protocol

dahlia · web-flow · commit f7e14bc97527 · 2026-02-03T14:52:13.000+01:00
Correct `workspace:` protocol usage
diff --git a/docs/package.json b/docs/package.json
@@ -3,25 +3,25 @@
     "@braintree/sanitize-url": "^7.1.1",
     "@cloudflare/workers-types": "catalog:",
     "@deno/kv": "^0.8.4",
-    "@fedify/amqp": "workspace:",
-    "@fedify/cfworkers": "workspace:",
-    "@fedify/express": "workspace:",
-    "@fedify/fastify": "workspace:",
-    "@fedify/fedify": "workspace:",
-    "@fedify/h3": "workspace:",
-    "@fedify/hono": "workspace:",
-    "@fedify/koa": "workspace:",
-    "@fedify/lint": "workspace:",
-    "@fedify/nestjs": "workspace:",
-    "@fedify/next": "workspace:",
-    "@fedify/postgres": "workspace:",
-    "@fedify/redis": "workspace:",
-    "@fedify/sqlite": "workspace:",
-    "@fedify/sveltekit": "workspace:",
-    "@fedify/testing": "workspace:",
-    "@fedify/vocab": "workspace:",
-    "@fedify/vocab-runtime": "workspace:",
-    "@fedify/relay": "workspace:",
+    "@fedify/amqp": "workspace:^",
+    "@fedify/cfworkers": "workspace:^",
+    "@fedify/express": "workspace:^",
+    "@fedify/fastify": "workspace:^",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/h3": "workspace:^",
+    "@fedify/hono": "workspace:^",
+    "@fedify/koa": "workspace:^",
+    "@fedify/lint": "workspace:^",
+    "@fedify/nestjs": "workspace:^",
+    "@fedify/next": "workspace:^",
+    "@fedify/postgres": "workspace:^",
+    "@fedify/redis": "workspace:^",
+    "@fedify/sqlite": "workspace:^",
+    "@fedify/sveltekit": "workspace:^",
+    "@fedify/testing": "workspace:^",
+    "@fedify/vocab": "workspace:^",
+    "@fedify/vocab-runtime": "workspace:^",
+    "@fedify/relay": "workspace:^",
     "@hono/node-server": "^1.13.7",
     "@js-temporal/polyfill": "catalog:",
     "@logtape/file": "catalog:",
diff --git a/examples/cloudflare-workers/package.json b/examples/cloudflare-workers/package.json
@@ -14,7 +14,7 @@
     "wrangler": "^4.18.0"
   },
   "dependencies": {
-    "@fedify/fedify": "workspace:",
-    "@fedify/vocab": "workspace:"
+    "@fedify/fedify": "workspace:^",
+    "@fedify/vocab": "workspace:^"
   }
 }
diff --git a/examples/elysia/package.json b/examples/elysia/package.json
@@ -32,7 +32,7 @@
   "dependencies": {
     "@fedify/elysia": "workspace:*",
     "@fedify/fedify": "workspace:*",
-    "@fedify/vocab": "workspace:",
+    "@fedify/vocab": "workspace:^",
     "elysia": "catalog:"
   }
 }
diff --git a/examples/express/package.json b/examples/express/package.json
@@ -30,9 +30,9 @@
     "typescript": "^5.5.4"
   },
   "dependencies": {
-    "@fedify/express": "workspace:",
-    "@fedify/fedify": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/express": "workspace:^",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "@logtape/logtape": "catalog:",
     "express": "catalog:"
   }
diff --git a/examples/fastify/package.json b/examples/fastify/package.json
@@ -8,9 +8,9 @@
     "dev": "tsx watch index.ts"
   },
   "dependencies": {
-    "@fedify/fastify": "workspace:",
-    "@fedify/fedify": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/fastify": "workspace:^",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "fastify": "catalog:"
   },
   "devDependencies": {
diff --git a/examples/koa/package.json b/examples/koa/package.json
@@ -30,9 +30,9 @@
     "typescript": "^5.5.4"
   },
   "dependencies": {
-    "@fedify/koa": "workspace:",
-    "@fedify/fedify": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/koa": "workspace:^",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "@logtape/logtape": "catalog:",
     "koa": "catalog:"
   }
diff --git a/examples/next-integration/package.json b/examples/next-integration/package.json
@@ -9,9 +9,9 @@
     "lint": "eslint"
   },
   "dependencies": {
-    "@fedify/fedify": "workspace:",
-    "@fedify/next": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/next": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "next": "15.5.0",
     "react": "19.1.0",
     "react-dom": "19.1.0",
diff --git a/examples/next14-app-router/package.json b/examples/next14-app-router/package.json
@@ -10,8 +10,8 @@
     "test": "true"
   },
   "dependencies": {
-    "@fedify/fedify": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "@logtape/logtape": "catalog:",
     "next": "^14.0.0",
     "react": "19.0.0-rc-7771d3a7-20240827",
diff --git a/examples/next15-app-router/package.json b/examples/next15-app-router/package.json
@@ -10,8 +10,8 @@
     "test": "true"
   },
   "dependencies": {
-    "@fedify/fedify": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "next": "15.3.1",
     "react": "^19.0.0",
     "react-dom": "^19.0.0",
diff --git a/examples/sveltekit-sample/package.json b/examples/sveltekit-sample/package.json
@@ -20,9 +20,9 @@
     "lint": "prettier --check . && eslint ."
   },
   "dependencies": {
-    "@fedify/fedify": "workspace:",
-    "@fedify/sveltekit": "workspace:",
-    "@fedify/vocab": "workspace:",
+    "@fedify/fedify": "workspace:^",
+    "@fedify/sveltekit": "workspace:^",
+    "@fedify/vocab": "workspace:^",
     "x-forwarded-fetch": "^0.2.0"
   },
   "devDependencies": {
diff --git a/mise.toml b/mise.toml
@@ -46,6 +46,7 @@ depends = [
   "check:types",
   "check:md",
   "check-versions",
+  "check:manifest:workspace-protocol",
 ]
 
 [tasks."check:fmt"]
@@ -75,6 +76,42 @@ else
 fi
 '''
 
+[tasks."check:manifest:workspace-protocol"]
+description = "Check for invalid workspace: specifiers without version (*, ^, ~)"
+run = '''
+found=0
+for file in $(find . -name 'package.json' -not -path '*/node_modules/*'); do
+  invalid=$(jq -r '
+    [
+      (.dependencies // {}),
+      (.devDependencies // {}),
+      (.peerDependencies // {}),
+      (.optionalDependencies // {})
+    ]
+    | add
+    | to_entries[]
+    | select(.value == "workspace:")
+    | "  \(.key)"
+  ' "$file" 2>/dev/null)
+  if [ -n "$invalid" ]; then
+    if [ "$found" -eq 0 ]; then
+      echo "Error: Found invalid workspace: specifiers (missing *, ^, or ~):"
+      echo ""
+    fi
+    echo "$file:"
+    echo "$invalid"
+    found=1
+  fi
+done
+
+if [ "$found" -eq 1 ]; then
+  echo ""
+  echo "Valid formats: workspace:*, workspace:^, workspace:~"
+  exit 1
+fi
+echo "All workspace: specifiers are valid"
+'''
+
 [tasks.fmt]
 description = "Format the codebase"
 run = "deno fmt && hongdown --write"
diff --git a/packages/fastify/package.json b/packages/fastify/package.json
@@ -47,7 +47,7 @@
     "fastify-plugin": "catalog:"
   },
   "peerDependencies": {
-    "@fedify/fedify": "workspace:",
+    "@fedify/fedify": "workspace:^",
     "fastify": "catalog:"
   },
   "devDependencies": {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`"wrangler": "^4.18.0"`
`15`	`15`	`},`
`16`	`16`	`"dependencies": {`
`17`		`- "@fedify/fedify": "workspace:",`
`18`		`- "@fedify/vocab": "workspace:"`
	`17`	`+ "@fedify/fedify": "workspace:^",`
	`18`	`+ "@fedify/vocab": "workspace:^"`
`19`	`19`	`}`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@`
`32`	`32`	`"dependencies": {`
`33`	`33`	`"@fedify/elysia": "workspace:*",`
`34`	`34`	`"@fedify/fedify": "workspace:*",`
`35`		`- "@fedify/vocab": "workspace:",`
	`35`	`+ "@fedify/vocab": "workspace:^",`
`36`	`36`	`"elysia": "catalog:"`
`37`	`37`	`}`
`38`	`38`	`}`