Comment to explain why rewrite request URLs

dahlia · dahlia · commit fdf809bb1362 · 2026-01-20T18:27:19.000+09:00
It explains the reason why we need to manually rewrite the request URL on Deno. #528 (comment)
diff --git a/packages/cli/src/tempserver.ts b/packages/cli/src/tempserver.ts
@@ -42,6 +42,8 @@ export async function spawnTemporaryServer(
   }
 
   const server = serve({
+    // Note that `protocol: "https"` does not work on Deno, so we need to
+    // manually rewrite the request URL to use https: on Deno:
     fetch: "Deno" in globalThis
       ? (request) => {
         const url = new URL(request.url);

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,8 @@ export async function spawnTemporaryServer(`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`const server = serve({`
	`45`	+ // Note that `protocol: "https"` does not work on Deno, so we need to
	`46`	`+ // manually rewrite the request URL to use https: on Deno:`
`45`	`47`	`fetch: "Deno" in globalThis`
`46`	`48`	`? (request) => {`
`47`	`49`	`const url = new URL(request.url);`