Skip to content

Load SolidStart init logging#730

Merged
dahlia merged 1 commit intofedify-dev:mainfrom
dahlia:bugfix/solidstart-logging
Apr 27, 2026
Merged

Load SolidStart init logging#730
dahlia merged 1 commit intofedify-dev:mainfrom
dahlia:bugfix/solidstart-logging

Conversation

@dahlia
Copy link
Copy Markdown
Member

@dahlia dahlia commented Apr 27, 2026

Summary

This fixes the SolidStart fedify init template so the generated src/logging.ts module is loaded from src/middleware/index.ts before Fedify handles requests.

The PR also adds a focused regression test in packages/init/src/webframeworks.test.ts to check that the generated SolidStart middleware imports the logging module.

Fixes #725

Tests

  • deno check packages/init/src/webframeworks.test.ts
  • hongdown --check CHANGES.md
  • pnpm --filter @fedify/init test
  • deno run -A packages/init/src/test/execute.ts init /tmp/fedify-init-725-solidstart -w solidstart -p npm -k in-memory -m in-process --dry-run
  • mise run check:types
  • git diff --check

Import the generated logging module from the SolidStart middleware
template so LogTape is configured before Fedify handles requests.
Add a regression test that checks the generated middleware imports it.

Fixes fedify-dev#725

Assisted-by: Codex:gpt-5.5
@dahlia dahlia added this to the Fedify 2.2 milestone Apr 27, 2026
@dahlia dahlia self-assigned this Apr 27, 2026
@dahlia dahlia added component/cli CLI tools related integration/solidstart SolidStart integration (@fedify/solidstart) labels Apr 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 209b9f4d-4de7-4a87-b2e9-654bd8cb2f49

📥 Commits

Reviewing files that changed from the base of the PR and between cb3394b and f7f2911.

📒 Files selected for processing (2)
  • packages/init/src/templates/solidstart/src/middleware/index.ts.tpl
  • packages/init/src/webframeworks.test.ts

📝 Walkthrough

Walkthrough

The SolidStart middleware template now imports the logging module as a side-effect before exporting the Fedify middleware. A test case validates that the generated middleware file includes this logging import, ensuring the logging configuration is wired into the framework at runtime.

Changes

Cohort / File(s) Summary
SolidStart Middleware Template
packages/init/src/templates/solidstart/src/middleware/index.ts.tpl
Added side-effect import of ../logging module to ensure logging configuration is initialized when the middleware loads.
Framework Initialization Tests
packages/init/src/webframeworks.test.ts
Added SolidStart-specific test case that verifies the generated middleware file exists and contains the logging module import statement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

component/integration

Suggested reviewers

  • 2chanhaeng
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title 'Load SolidStart init logging' accurately describes the main change: adding logging module import to SolidStart middleware template.
Description check ✅ Passed Description clearly explains the fix for SolidStart logging in the init template and references issue #725, with appropriate test commands.
Linked Issues check ✅ Passed PR fully addresses the SolidStart objective from issue #725: imports logging module from middleware entry point before Fedify handles requests, with regression test.
Out of Scope Changes check ✅ Passed All changes are scoped to SolidStart init template and its test; no unrelated modifications to other frameworks or components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@issues-auto-labeler issues-auto-labeler Bot added breaking change Requires backward-incompatible change component/build Build system and packaging labels Apr 27, 2026
@dahlia
Copy link
Copy Markdown
Member Author

dahlia commented Apr 27, 2026

@codex review

@dahlia dahlia removed breaking change Requires backward-incompatible change component/build Build system and packaging labels Apr 27, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a SolidStart template to the @fedify/init package, including the addition of logging middleware and a new test case to verify its inclusion. The feedback suggests appending the .ts extension to the logging import path in both the template and the test suite to ensure Deno compatibility and maintain consistency across the project's templates.

Comment thread packages/init/src/templates/solidstart/src/middleware/index.ts.tpl
Comment thread packages/init/src/webframeworks.test.ts
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dahlia dahlia requested a review from 2chanhaeng April 27, 2026 03:53
Copy link
Copy Markdown
Contributor

@2chanhaeng 2chanhaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@dahlia dahlia merged commit 02642d2 into fedify-dev:main Apr 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/cli CLI tools related integration/solidstart SolidStart integration (@fedify/solidstart)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit fedify init templates that generate unused logging.ts

2 participants