Load SolidStart init logging#730
Conversation
Import the generated logging module from the SolidStart middleware template so LogTape is configured before Fedify handles requests. Add a regression test that checks the generated middleware imports it. Fixes fedify-dev#725 Assisted-by: Codex:gpt-5.5
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe SolidStart middleware template now imports the logging module as a side-effect before exporting the Fedify middleware. A test case validates that the generated middleware file includes this logging import, ensuring the logging configuration is wired into the framework at runtime. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
There was a problem hiding this comment.
Code Review
This pull request adds a SolidStart template to the @fedify/init package, including the addition of logging middleware and a new test case to verify its inclusion. The feedback suggests appending the .ts extension to the logging import path in both the template and the test suite to ensure Deno compatibility and maintain consistency across the project's templates.
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary
This fixes the SolidStart
fedify inittemplate so the generated src/logging.ts module is loaded from src/middleware/index.ts before Fedify handles requests.The PR also adds a focused regression test in packages/init/src/webframeworks.test.ts to check that the generated SolidStart middleware imports the logging module.
Fixes #725
Tests
deno check packages/init/src/webframeworks.test.tshongdown --check CHANGES.mdpnpm --filter @fedify/init testdeno run -A packages/init/src/test/execute.ts init /tmp/fedify-init-725-solidstart -w solidstart -p npm -k in-memory -m in-process --dry-runmise run check:typesgit diff --check