Skip to content

Commit 32226ca

Browse files
committed
Remove always-empty stderr log when stdout/stderr pipes are unavailable
When stdout or stderr is null, no listener has been registered yet, so stderrChunks is always empty at that point. The ffmpeg output log would always produce an empty string, so remove it. Suggested by @dahlia in PR review.
1 parent 0b39057 commit 32226ca

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

src/media.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ export async function makeVideoScreenshot(
103103
logger.error(
104104
"Could not build pipes to ffmpeg, can't create a video screenshot",
105105
);
106-
logger.error("ffmpeg output: {stderr}", {
107-
stderr: Buffer.concat(stderrChunks).toString(),
108-
});
109106
resolve(defaultScreenshot);
110107
return;
111108
}

0 commit comments

Comments
 (0)