Merge pull request #179 from notJoon/fix/issue-177

fix(api): Accept null values for optional fields in /api/v1/statuses endpoin

Author: ThisIsMissEm

src/api/v1/statuses.test.ts

@@ -169,4 +169,45 @@ describe.sequential("/api/v1/accounts/verify_credentials", () => {
     expect(typeof updateJson).toBe("object");
     expect(updateJson.content).toBe("<p>Test Update</p>\n");
   });
+
+  it("Issue 177: successfully creates a status with null values, setting appropriate defaults", async () => {
+    const body = JSON.stringify({
+      language: null,
+      status: "Awoo!",
+      in_reply_to_id: null,
+      sensitive: false,
+      spoiler_text: null,
+      media_ids: null,
+      visibility: null,
+      poll: null,
+    });
+
+    const response = await app.request("/api/v1/statuses", {
+      method: "POST",
+      headers: {
+        authorization: bearerAuthorization(accessToken),
+        "Content-Type": "application/json",
+      },
+      body: body,
+    });
+
+    expect(response.status).toBe(200);
+    expect(response.headers.get("content-type")).toBe("application/json");
+
+    const json = await response.json();
+    expect(typeof json).toBe("object");
+
+    // Basic creation success
+    expect(json.content).toBe("<p>Awoo!</p>\n");
+    expect(json.account.id).toBe(account.id);
+
+    // Verify null values are replaced with appropriate defaults
+    expect(json.visibility).not.toBeNull();
+    expect(json.visibility).toBe("public");
+    expect(json.spoiler_text).toBe("");
+    expect(json.media_attachments).toEqual([]);
+    expect(json.sensitive).toBe(false);
+    expect(json.language).not.toBeNull();
+    expect(json.poll).toBeNull(); // This one stays null as expected
+  });
 });

src/api/v1/statuses.ts

@@ -160,8 +160,8 @@ function buildMuteAndBlockConditions(viewerAccountId: Uuid | null | undefined) {
 }
 
 const statusSchema = z.object({
-  status: z.string().min(1).optional(),
-  media_ids: z.array(uuid).optional(),
+  status: z.string().min(1).optional().nullable(),
+  media_ids: z.array(uuid).optional().nullable(),
   poll: z
     .object({
       options: z.array(z.string()),
@@ -175,18 +175,22 @@ const statusSchema = z.object({
       multiple: z.boolean().default(false),
       hide_totals: z.boolean().default(false),
     })
-    .optional(),
+    .optional()
+    .nullable(),
   sensitive: z.boolean().default(false),
-  spoiler_text: z.string().optional(),
-  language: z.string().min(2).optional(),
+  spoiler_text: z.string().optional().nullable(),
+  language: z.string().min(2).optional().nullable(),
 });
 
 const createStatusSchema = statusSchema.merge(
   z.object({
-    in_reply_to_id: uuid.optional(),
-    quote_id: uuid.optional(),
-    visibility: z.enum(["public", "unlisted", "private", "direct"]).optional(),
-    scheduled_at: z.string().datetime().optional(),
+    in_reply_to_id: uuid.optional().nullable(),
+    quote_id: uuid.optional().nullable(),
+    visibility: z
+      .enum(["public", "unlisted", "private", "direct"])
+      .optional()
+      .nullable(),
+    scheduled_at: z.string().datetime().optional().nullable(),
   }),
 );
 

src/text.ts

@@ -272,7 +272,7 @@ export async function formatPostContent(
     ExtractTablesWithRelations<typeof schema>
   >,
   text: string,
-  language: string | undefined,
+  language: string | null | undefined,
   options: {
     url: URL | string;
     contextLoader?: DocumentLoader;