Merge tag '0.7.7'

Hollo 0.7.7

Author: dahlia

CHANGES.md

@@ -86,6 +86,19 @@ To be released.
 [Fedify debugger]: https://fedify.dev/manual/debug
 
 
+Version 0.7.7
+-------------
+
+Released on March 13, 2026.
+
+ -  Fixed video thumbnail generation failing for some MP4/MOV files by writing
+    the video data to a temporary file instead of piping it via stdin (`pipe:0`),
+    which does not support seeking.  [[#397], [#398] by NTSK]
+
+[#397]: https://github.com/fedify-dev/hollo/issues/397
+[#398]: https://github.com/fedify-dev/hollo/pull/398
+
+
 Version 0.7.6
 -------------
 

src/media.ts

@@ -1,5 +1,7 @@
 import { spawn } from "node:child_process";
 import { readFileSync } from "node:fs";
+import { mkdtemp, rm, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { getLogger } from "@logtape/logtape";
 import type { Sharp } from "sharp";
@@ -78,59 +80,72 @@ export function calculateThumbnailSize(
 export async function makeVideoScreenshot(
   videoData: Uint8Array,
 ): Promise<Uint8Array> {
-  const resultBuffer: Buffer = await new Promise((resolve, _) => {
-    const process = spawn("ffmpeg", [
-      "-i",
-      "pipe:0",
-      "-vframes",
-      "1",
-      "-f",
-      "image2pipe",
-      "pipe:1",
-    ]);
-    const stdin = process.stdin;
-    const stdout = process.stdout;
-    const stderr = process.stderr;
-    const chunks: Buffer[] = [];
-    const stderrChunks: Buffer[] = [];
-    if (!stdin || !stdout || !stderr) {
-      logger.error(
-        "Could not build pipes to ffmpeg, can't create a video screenshot",
-      );
-      logger.error("ffmpeg output: {stderr}", {
-        stderr: Buffer.concat(stderrChunks).toString(),
+  let tmpDir: string | undefined;
+  try {
+    tmpDir = await mkdtemp(join(tmpdir(), "hollo-"));
+    const inFile = join(tmpDir, "video");
+    await writeFile(inFile, videoData);
+    const resultBuffer: Buffer = await new Promise((resolve) => {
+      const process = spawn("ffmpeg", [
+        "-i",
+        inFile,
+        "-vframes",
+        "1",
+        "-f",
+        "image2pipe",
+        "pipe:1",
+      ]);
+      const stdout = process.stdout;
+      const stderr = process.stderr;
+      const chunks: Buffer[] = [];
+      const stderrChunks: Buffer[] = [];
+      if (!stdout || !stderr) {
+        logger.error(
+          "Could not build pipes to ffmpeg, can't create a video screenshot",
+        );
+        resolve(defaultScreenshot);
+        return;
+      }
+      stdout.on("data", (chunk) => {
+        chunks.push(chunk);
       });
-      resolve(defaultScreenshot);
-    }
-    stdout.on("data", (chunk) => {
-      chunks.push(chunk);
-    });
-    stderr.on("data", (chunk) => {
-      stderrChunks.push(chunk);
-    });
-    process.on("close", (code) => {
-      if (code !== 0) {
-        logger.error("ffmpeg returned a bad error code {code}", { code });
+      stderr.on("data", (chunk) => {
+        stderrChunks.push(chunk);
+      });
+      process.on("close", (code) => {
+        if (code !== 0) {
+          logger.error("ffmpeg returned a bad error code {code}", { code });
+          logger.error("ffmpeg output: {stderr}", {
+            stderr: Buffer.concat(stderrChunks).toString(),
+          });
+          resolve(defaultScreenshot);
+          return;
+        }
+        resolve(Buffer.concat(chunks));
+      });
+      process.on("error", (error) => {
+        logger.error("Could not run ffmpeg: {error}", { error });
         logger.error("ffmpeg output: {stderr}", {
           stderr: Buffer.concat(stderrChunks).toString(),
         });
         resolve(defaultScreenshot);
-      }
-      resolve(Buffer.concat(chunks));
-    });
-    process.on("error", (error) => {
-      logger.error("Could not run ffmpeg: {error}", { error });
-      logger.error("ffmpeg output: {stderr}", {
-        stderr: Buffer.concat(stderrChunks).toString(),
       });
-      resolve(defaultScreenshot);
     });
-    stdin.on("error", (_) => {
-      // probably a EPIPE because ffmpeg does not consume the whole file; swallow it here
+    return resultBuffer;
+  } catch (error) {
+    logger.error("Could not prepare temporary file for ffmpeg: {error}", {
+      error,
     });
-
-    stdin.write(videoData);
-    stdin.end();
-  });
-  return resultBuffer;
+    return defaultScreenshot;
+  } finally {
+    if (tmpDir) {
+      try {
+        await rm(tmpDir, { recursive: true, force: true });
+      } catch (cleanupError) {
+        logger.warn("Failed to clean up temporary directory: {error}", {
+          error: cleanupError,
+        });
+      }
+    }
+  }
 }