Skip to content
This repository was archived by the owner on Nov 8, 2019. It is now read-only.

Redesign mysql image to work in OpenShift as well#193

Closed
hhorak wants to merge 1 commit into
fedora-cloud:masterfrom
hhorak:openshift-compatible-mysql3
Closed

Redesign mysql image to work in OpenShift as well#193
hhorak wants to merge 1 commit into
fedora-cloud:masterfrom
hhorak:openshift-compatible-mysql3

Conversation

@hhorak
Copy link
Copy Markdown
Contributor

@hhorak hhorak commented Mar 31, 2016

This is a counter-proposal to PR #191, not meant in sense "let's make it my way", but rather to show in practice what I was talking about. I definitely don't say it must be this way, but where I'd like to get from here is to find a common way which will work for most people.

These changes are based on the code that from https://github.com/openshift/mysql, but it does not include some recent changes in the scripts. Even if the image is meant to work in OpenShift, it doesn't mean that it shouldn't work outside of OpenShift -- the opposite is true, the image should be usable on Atomic or normal Fedora Server/Workstation/Cloud without any issues as well.

I'd like to apology in advance that I won't be responsive in next two weeks, since I'll be off-line.

Comment thread mysql/Dockerfile
MAINTAINER http://fedoraproject.org/wiki/Cloud

# RUN echo %sudo ALL=NOPASSWD: ALL >> /etc/sudoers
ENV MYSQL_VERSION=10.0 \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.6? But see below.

@sourcejedi
Copy link
Copy Markdown
Contributor

The second commit I wanted to make was that the SCL image used restorecon inside Docker, which wouldn't do anything. So I'm happy that I couldn't find it in this version :).

@sourcejedi
Copy link
Copy Markdown
Contributor

PS I should have said, I wish you well in your time offline, wherever that may be :).

@hhorak
Copy link
Copy Markdown
Contributor Author

hhorak commented May 26, 2016

@sourcejedi Very sorry for long delay in responses. I've created a new variant of the PR (#219), that is based on recent code from https://github.com/openshift/mysql. Some of the issues you pointed are fixed there, thank you very much. Some are not yet (options for configuration, password handling), but I'd rather change those later, after thinking through it more.
Anyway, since there is the new PR #219 created, closing this one.

@hhorak hhorak closed this May 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants