This repository was archived by the owner on Nov 8, 2019. It is now read-only.
Redesign mysql image to work in OpenShift as well#193
Closed
hhorak wants to merge 1 commit into
Closed
Conversation
This was referenced Mar 31, 2016
| MAINTAINER http://fedoraproject.org/wiki/Cloud | ||
|
|
||
| # RUN echo %sudo ALL=NOPASSWD: ALL >> /etc/sudoers | ||
| ENV MYSQL_VERSION=10.0 \ |
Contributor
|
The second commit I wanted to make was that the SCL image used |
Contributor
|
PS I should have said, I wish you well in your time offline, wherever that may be :). |
Contributor
Author
|
@sourcejedi Very sorry for long delay in responses. I've created a new variant of the PR (#219), that is based on recent code from https://github.com/openshift/mysql. Some of the issues you pointed are fixed there, thank you very much. Some are not yet (options for configuration, password handling), but I'd rather change those later, after thinking through it more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a counter-proposal to PR #191, not meant in sense "let's make it my way", but rather to show in practice what I was talking about. I definitely don't say it must be this way, but where I'd like to get from here is to find a common way which will work for most people.
These changes are based on the code that from https://github.com/openshift/mysql, but it does not include some recent changes in the scripts. Even if the image is meant to work in OpenShift, it doesn't mean that it shouldn't work outside of OpenShift -- the opposite is true, the image should be usable on Atomic or normal Fedora Server/Workstation/Cloud without any issues as well.
I'd like to apology in advance that I won't be responsive in next two weeks, since I'll be off-line.