Skip to content

Add markup to copr-rpmbuild man page#4333

Open
mariobl wants to merge 2 commits into
fedora-copr:mainfrom
mariobl:main
Open

Add markup to copr-rpmbuild man page#4333
mariobl wants to merge 2 commits into
fedora-copr:mainfrom
mariobl:main

Conversation

@mariobl
Copy link
Copy Markdown

@mariobl mariobl commented May 31, 2026

This commit adds some minimal markup to the copr-rpmbuild man page, according to the rules in man-pages.7.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the formatting of the copr-rpmbuild asciidoc man page by bolding options and italicizing file paths and placeholders. The reviewer feedback suggests enhancing consistency with the SYNOPSIS section by documenting the short options (-c, -d, -r, -v, -h) alongside their corresponding long options in the OPTIONS section, as well as italicizing an additional log file path.

Comment thread rpmbuild/man/copr-rpmbuild.1.asciidoc Outdated
Comment on lines +27 to +28
*--config* _CONFIG_PATH_::
Path to an alternative config file. By default _/etc/copr-rpmbuild/main.ini_ is used.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For completeness and consistency with the SYNOPSIS section, document the short option -c alongside the long option --config.

*-c*, *--config* _CONFIG_PATH_::
    Path to an alternative config file. By default _/etc/copr-rpmbuild/main.ini_ is used.

Comment thread rpmbuild/man/copr-rpmbuild.1.asciidoc Outdated
Comment on lines 30 to 31
*--detached*::
Run build in background and output the process PID. Log into /var/lib/copr-rpmbuild/main.log.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Document the short option -d alongside the long option --detached for completeness. Additionally, format the log file path _/var/lib/copr-rpmbuild/main.log_ in italics to maintain consistency with other file paths in the document.

*-d*, *--detached*::
    Run build in background and output the process PID. Log into _/var/lib/copr-rpmbuild/main.log_.

Comment thread rpmbuild/man/copr-rpmbuild.1.asciidoc Outdated
Comment on lines +33 to +34
*--chroot* _CHROOT_NAME_::
Name of the chroot to build for. This follows mock's convention for naming chroots (e.g. fedora-27-x86_64). See _/etc/mock_ for the full list.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For completeness and consistency with the SYNOPSIS section, document the short option -r alongside the long option --chroot.

*-r*, *--chroot* _CHROOT_NAME_::
    Name of the chroot to build for. This follows mock's convention for naming chroots (e.g. fedora-27-x86_64). See _/etc/mock_ for the full list.

Comment thread rpmbuild/man/copr-rpmbuild.1.asciidoc Outdated
Build RPM. This is the default action. Requires *--chroot* to be specified.

--verbose::
*--verbose*::
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For completeness and consistency with the SYNOPSIS section, document the short option -v alongside the long option --verbose.

*-v*, *--verbose*::

Comment thread rpmbuild/man/copr-rpmbuild.1.asciidoc Outdated
Print debugging information.

--help::
*--help*::
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For completeness and consistency with the SYNOPSIS section, document the short option -h alongside the long option --help.

*-h*, *--help*::

@mariobl
Copy link
Copy Markdown
Author

mariobl commented Jun 1, 2026

The second commit applies the recommendations by gemini-code-assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant