Eliminate all warnings

Author: mizdebsk

xmvn-api/src/test/java/org/fedoraproject/xmvn/artifact/DefaultArtifactTest.java

@@ -275,6 +275,7 @@ public void testToString()
      * Test if equality behaves sanely.
      */
     @Test
+    @SuppressWarnings( "unlikely-arg-type" )
     public void testEquals()
         throws Exception
     {

xmvn-api/src/test/java/org/fedoraproject/xmvn/deployer/DeploymentRequestTest.java

@@ -142,7 +142,7 @@ public void addAndGetDependenciesTest()
         deployRq.removeDependency( dependencyB );
 
         // tests adding optional dependency without exclusions
-        deployRq.addDependency( dependencyB, true, new ArrayList() );
+        deployRq.addDependency( dependencyB, true, new ArrayList<>() );
         listedDependencies = deployRq.getDependencies();
         dsc = listedDependencies.get( 1 );
         Assert.assertTrue( dsc.isOptional() );

xmvn-connector-aether/src/main/java/org/fedoraproject/xmvn/connector/aether/XMvnMojoExecutionListener.java

@@ -108,7 +108,8 @@ void setXmvnStateDir( Path xmvnStateDir )
         this.xmvnStateDir = xmvnStateDir;
     }
 
-    private Object dispatchBuildPluginManagerMethodCall( Object proxy, Method method, Object[] args )
+    private Object dispatchBuildPluginManagerMethodCall( @SuppressWarnings( "unused" ) Object proxy, Method method,
+                                                         Object[] args )
         throws Throwable
     {
         Object ret = method.invoke( mavenPluginManager, args );

xmvn-connector-aether/src/test/java/org/fedoraproject/xmvn/connector/aether/ModelValidatorTest.java

@@ -19,6 +19,7 @@
 import static org.junit.Assert.assertTrue;
 
 import java.io.FileReader;
+import java.io.Reader;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.ArrayList;
@@ -80,7 +81,10 @@ public void setUp()
         validator = lookup( ModelValidator.class );
 
         Xpp3Dom mainCfg, glCfg, locCfg;
-        mainCfg = Xpp3DomBuilder.build( new FileReader( getResource( "test.pom.xml" ).toFile() ) );
+        try ( Reader reader = new FileReader( getResource( "test.pom.xml" ).toFile() ) )
+        {
+            mainCfg = Xpp3DomBuilder.build( reader );
+        }
         glCfg = mainCfg.getChild( "basic" ).getChild( "configuration" );
 
         dl = new ArrayList<>();

xmvn-mojo/src/main/java/org/fedoraproject/xmvn/mojo/BuilddepMojo.java

@@ -176,6 +176,7 @@ private Set<Artifact> getModelDependencies( Model model )
         return visitor.getArtifacts();
     }
 
+    @SuppressWarnings( "resource" )
     private Lifecycle getDefaultLifecycle( MavenProject project )
         throws MojoExecutionException
     {

xmvn-tools/xmvn-install/src/test/java/org/fedoraproject/xmvn/tools/install/impl/ArtifactInstallerFactoryTest.java

@@ -56,6 +56,7 @@ public void testMissingPlugin()
     }
 
     @Test
+    @SuppressWarnings( "deprecation" )
     public void testValidPlugin()
         throws Exception
     {