Improve e2e tests: use tmp_path and pytest.raises

The two --rpm-dir tests patched os.path.isdir and glob.glob directly,
coupling the tests to implementation internals (the fact that the code uses
os.path.isdir rather than pathlib, for example).

Replace the mocked filesystem calls with real filesystem state:
- test_cli_rpm_dir_not_found: pass tmp_path / 'nonexistent', which is a
  genuinely non-existent directory with no patching needed.
- test_cli_rpm_dir_no_rpms: pass the empty tmp_path directly.

Replace the try/except SystemExit pattern with pytest.raises(SystemExit) in
all three tests, which is the idiomatic pytest style.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: frenzymadness

tests/e2e/test_cli_rpm_mode.py

@@ -4,57 +4,45 @@
 Tests the command-line interface with --rpms and --rpm-dir options.
 """
 
+import pytest
 from unittest.mock import patch
 from fedora_revdep_check import main
 
 
 class TestCLIRPMMode:
     """Test CLI with --rpms option."""
 
-    def test_cli_rpm_dir_not_found(self, capsys):
+    def test_cli_rpm_dir_not_found(self, tmp_path, capsys):
         """Test CLI with --rpm-dir when directory doesn't exist."""
-        test_args = ['fedora-revdep-check', '--rpm-dir', '/nonexistent']
+        nonexistent = tmp_path / 'nonexistent'
+        test_args = ['fedora-revdep-check', '--rpm-dir', str(nonexistent)]
 
-        with patch('sys.argv', test_args), \
-             patch('os.path.isdir', return_value=False):
-
-            exit_code = 0
-            try:
+        with patch('sys.argv', test_args):
+            with pytest.raises(SystemExit) as excinfo:
                 main()
-            except SystemExit as e:
-                exit_code = e.code
 
-            assert exit_code == 1
-            captured = capsys.readouterr()
-            assert 'Directory not found' in captured.err
+        assert excinfo.value.code == 1
+        captured = capsys.readouterr()
+        assert 'Directory not found' in captured.err
 
-    def test_cli_rpm_dir_no_rpms(self, capsys):
+    def test_cli_rpm_dir_no_rpms(self, tmp_path, capsys):
         """Test CLI with --rpm-dir when directory has no RPM files."""
-        test_args = ['fedora-revdep-check', '--rpm-dir', '/tmp/empty']
+        test_args = ['fedora-revdep-check', '--rpm-dir', str(tmp_path)]
 
-        with patch('sys.argv', test_args), \
-             patch('os.path.isdir', return_value=True), \
-             patch('glob.glob', return_value=[]):
-
-            exit_code = 0
-            try:
+        with patch('sys.argv', test_args):
+            with pytest.raises(SystemExit) as excinfo:
                 main()
-            except SystemExit as e:
-                exit_code = e.code
 
-            assert exit_code == 1
-            captured = capsys.readouterr()
-            assert 'No .rpm files found' in captured.err
+        assert excinfo.value.code == 1
+        captured = capsys.readouterr()
+        assert 'No .rpm files found' in captured.err
 
     def test_cli_missing_arguments(self, capsys):
         """Test CLI with no arguments shows error."""
         test_args = ['fedora-revdep-check']
 
         with patch('sys.argv', test_args):
-            exit_code = 0
-            try:
+            with pytest.raises(SystemExit) as excinfo:
                 main()
-            except SystemExit as e:
-                exit_code = e.code
 
-            assert exit_code == 2  # argparse error
+        assert excinfo.value.code == 2  # argparse error