Skip to content

Commit ccc9f31

Browse files
committed
these ultimately need to be redone
1 parent 527721a commit ccc9f31

10 files changed

Lines changed: 32 additions & 32 deletions

components/DownloadIconButton.jsx

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable jsx-a11y/no-interactive-element-to-noninteractive-role */
12
/**
23
* DownloadIconButton.jsx
34
* Created by Lizzie Salita 7/9/20
@@ -41,25 +42,23 @@ const DownloadIconButton = ({
4142

4243
if (tooltipComponent) {
4344
return (
44-
<>
45-
<TooltipWrapper
46-
className={`usda-download-btn${disabledClass}`}
47-
tooltipPosition={tooltipPosition}
48-
tooltipComponent={tooltipComponent} />
45+
<TooltipWrapper
46+
className={`usda-download-btn${disabledClass}`}
47+
tooltipPosition={tooltipPosition}
48+
tooltipComponent={tooltipComponent}>
4949
<button
5050
type="button"
51+
role="presentation"
5152
className="usda-button"
5253
title={buttonText}
53-
aria-label={buttonText}
5454
disabled={downloadInFlight || !isEnabled}
5555
onClick={startDownload}
5656
style={{ backgroundColor }}
57-
tabIndex={!isEnabled ? -1 : 0}
58-
aria-hidden={!isEnabled}>
57+
tabIndex={!isEnabled ? -1 : 0}>
5958
<FontAwesomeIcon icon={icon} spin={downloadInFlight} color="#dfe1e2" />
6059
<span style={{ color: '#dfe1e2' }}>{buttonText}</span>
6160
</button>
62-
</>
61+
</TooltipWrapper>
6362
);
6463
}
6564
return (
@@ -83,4 +82,4 @@ const DownloadIconButton = ({
8382

8483
DownloadIconButton.displayName = 'Download Icon Button';
8584
DownloadIconButton.propTypes = propTypes;
86-
export default DownloadIconButton;
85+
export default DownloadIconButton;

components/infoTooltip/TooltipWrapper.jsx

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable jsx-a11y/no-noninteractive-tabindex */
12
/**
23
* Tooltip.jsx
34
* Created by Lizzie Salita 3/8/19
@@ -305,21 +306,22 @@ const TooltipWrapper = ({
305306
<div
306307
ref={(div) => {
307308
tooltipContainer.current = div;
308-
}}
309-
role="button"
310-
tabIndex="0"
311-
aria-label="Tooltip Hover Wrapper"
312-
className="tooltip__hover-wrapper"
313-
onBlur={closeTooltip}
314-
onFocus={showTooltipFunc}
315-
onKeyPress={showTooltipFunc}
316-
onMouseEnter={showTooltipFunc}
317-
onMouseLeave={closeTooltip}
318-
onClick={showTooltipFunc}>
319-
{icon && tooltipIcons[icon]}
309+
}}>
310+
<div
311+
role="presentation"
312+
tabIndex="0"
313+
className="tooltip__hover-wrapper"
314+
onBlur={closeTooltip}
315+
onFocus={showTooltipFunc}
316+
onKeyPress={showTooltipFunc}
317+
onMouseEnter={showTooltipFunc}
318+
onMouseLeave={closeTooltip}
319+
onClick={showTooltipFunc}>
320+
{children}
321+
{icon && tooltipIcons[icon]}
322+
</div>
323+
{tooltip}
320324
</div>
321-
{children}
322-
{tooltip}
323325
</div>
324326
);
325327
};

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/iframe.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -623,8 +623,8 @@
623623

624624
import './mocker-runtime-injected.js';
625625

626-
import './runtime~main.45e54683.iframe.bundle.js';
626+
import './runtime~main.82744e83.iframe.bundle.js';
627627

628628
import './6094.566847d9.iframe.bundle.js';
629629

630-
import './main.1f494544.iframe.bundle.js';</script></body></html>
630+
import './main.35c16da8.iframe.bundle.js';</script></body></html>
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"generatedAt":1771357960672,"userSince":1747848640087,"hasCustomBabel":false,"hasCustomWebpack":true,"hasStaticDirs":false,"hasStorybookEslint":false,"refCount":0,"testPackages":{"@babel/plugin-transform-optional-chaining":"7.27.1","@chromatic-com/storybook":"4.1.1","@testing-library/jest-dom":"6.8.0","@testing-library/react":"14.0.0","eslint-plugin-jasmine":"2.10.1","jest":"28.1.3","jest-cli":"28.1.3"},"hasRouterPackage":false,"packageManager":{"type":"npm","agent":"npm","nodeLinker":"node_modules"},"typescriptOptions":{"reactDocgen":"react-docgen-typescript"},"preview":{"usesGlobals":false},"framework":{"name":"@storybook/react-webpack5","options":{}},"builder":"@storybook/builder-webpack5","renderer":"@storybook/react","portableStoriesFileCount":5,"applicationFileCount":9,"storybookVersion":"9.1.3","language":"typescript","storybookPackages":{"@storybook/addon-a11y":{"version":"9.1.3"},"@storybook/react-webpack5":{"version":"9.1.3"},"storybook":{"version":"9.1.3"}},"addons":{"@storybook/addon-links":{"version":"9.1.3"},"@storybook/addon-webpack5-compiler-babel":{"version":"3.0.6"},"@chromatic-com/storybook":{"version":"4.1.1"},"@storybook/addon-docs":{"version":"9.1.3"},"@storybook/addon-styling-webpack":{"version":"2.0.0"}}}
1+
{"generatedAt":1771446693868,"userSince":1747848640087,"hasCustomBabel":false,"hasCustomWebpack":true,"hasStaticDirs":false,"hasStorybookEslint":false,"refCount":0,"testPackages":{"@babel/plugin-transform-optional-chaining":"7.27.1","@chromatic-com/storybook":"4.1.1","@testing-library/jest-dom":"6.8.0","@testing-library/react":"14.0.0","eslint-plugin-jasmine":"2.10.1","jest":"28.1.3","jest-cli":"28.1.3"},"hasRouterPackage":false,"packageManager":{"type":"npm","agent":"npm","nodeLinker":"node_modules"},"typescriptOptions":{"reactDocgen":"react-docgen-typescript"},"preview":{"usesGlobals":false},"framework":{"name":"@storybook/react-webpack5","options":{}},"builder":"@storybook/builder-webpack5","renderer":"@storybook/react","portableStoriesFileCount":5,"applicationFileCount":9,"storybookVersion":"9.1.3","language":"typescript","storybookPackages":{"@storybook/addon-a11y":{"version":"9.1.3"},"@storybook/react-webpack5":{"version":"9.1.3"},"storybook":{"version":"9.1.3"}},"addons":{"@storybook/addon-links":{"version":"9.1.3"},"@storybook/addon-webpack5-compiler-babel":{"version":"3.0.6"},"@chromatic-com/storybook":{"version":"4.1.1"},"@storybook/addon-docs":{"version":"9.1.3"},"@storybook/addon-styling-webpack":{"version":"2.0.0"}}}

docs/runtime~main.45e54683.iframe.bundle.js renamed to docs/runtime~main.82744e83.iframe.bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/stories-page-header-stories.a2d1918e.iframe.bundle.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

docs/stories-page-header-stories.f6de2c7f.iframe.bundle.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

styles/components/_downloadIconButton.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
@import "../global/index";
2-
32
.usda-download-btn {
43
padding-bottom: rem(2);
54
display: flex;

0 commit comments

Comments
 (0)