Skip to content

DEV 15201: Add remaining new banners - Federal Spending Guide, Data Sources, and COVID-19 DS&M#5374

Merged
anjenkin merged 31 commits into
qatfrom
mod/dev-15201
Jul 8, 2026
Merged

DEV 15201: Add remaining new banners - Federal Spending Guide, Data Sources, and COVID-19 DS&M#5374
anjenkin merged 31 commits into
qatfrom
mod/dev-15201

Conversation

@jdhfrb

@jdhfrb jdhfrb commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description:
Many style changes, clean up, new Download Share component for not in header bar, modified some page content to match mocks.

JIRA Ticket:
DEV-15201

Mockup:
https://figma-gov.com/design/y2Uy2WA9T6s5AbHR2JdSe4/Covid-Page---Banners?node-id=299-1592&p=f&m=dev

The following are ALL required for the PR to be merged:

Author:

  • Linked to this PR in JIRA ticket
  • Scheduled and completed design review
  • Provided instructions for testing in JIRA ticket and PR if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome extension or Lighthouse report)
  • Added Unit Tests for helper functions, reducers, models and Container/Component Interactivity Expectations if applicable React Testing Library
  • API contract updated if applicable

@jdhfrb jdhfrb added do not merge pending design review design review approval needed before merging labels Jun 24, 2026
@anjenkin anjenkin self-assigned this Jun 24, 2026
@jdhfrb jdhfrb removed do not merge pending design review design review approval needed before merging labels Jun 24, 2026

@anjenkin anjenkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The in-page nav items jump to each section based on the header height. now that the header heights have changed on the following pages, the in-page nav links are broken and don't jump to the correct section.

Also, i'm getting a console error when opening the covid-19 ds&m.

Image

Comment thread src/_scss/pages/trainingVideos/trainingVideos.scss Outdated
Comment thread src/js/components/covid19/Covid19Page.jsx
@jdhfrb jdhfrb added do not merge pending sprint start to be merged after code freeze ends, at the start of a new sprint labels Jun 25, 2026
@jdhfrb jdhfrb removed do not merge pending sprint start to be merged after code freeze ends, at the start of a new sprint labels Jul 2, 2026

@anjenkin anjenkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more things -

Image Image

on the data sources page, the formatting behind the usas data model section is messed up in this branch, i think there's something throwing off the css
the banner on the covid page is sticky when it shouldn't be and the formatting is weird but we could fix that with a separate ticket.

@jdhfrb jdhfrb requested a review from anjenkin July 8, 2026 15:23
@anjenkin anjenkin merged commit f291242 into qat Jul 8, 2026
6 checks passed
@anjenkin anjenkin deleted the mod/dev-15201 branch July 8, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants