Skip to content

sanitize wiki names in lineup up#211

Open
paul90 wants to merge 1 commit into
mainfrom
lineup-colon
Open

sanitize wiki names in lineup up#211
paul90 wants to merge 1 commit into
mainfrom
lineup-colon

Conversation

@paul90

@paul90 paul90 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Remove any trailing : which create an alias pointing the wiki without the :

When adding a : to the name of a wiki in the line-up the browser quietly add the default port, but the wiki-client will see it as a wiki with a name ending with a :.

This becomes a problem when pages are forked, or items dragged of pages, in that wiki. The journal entry for these events will get marked with the site ending with :.

If the wiki without the trailing : is also the neighbourhood all pages from one with be marked as having an identical twin from the other.

Federation search will also see it as a separate wiki, and report it as such in recent changes. In the roster plugin, when displaying the recent activity roster, ROSTER query.search.federatedwiki.org/recent-activity, these are see as roster categories not wiki sites.
Screenshot 2026-06-24 at 18 18 31

By removing the trailing : this source that can introduce this problem.

It does not address correction of any entries that have been added to a page's journal. This will be addressed in an upcoming version of the journalmatic plugin.

remove any trailing ':' which create an alias pointing the wiki without
the ':'
@WardCunningham WardCunningham self-assigned this Jul 1, 2026
@WardCunningham

Copy link
Copy Markdown
Member

I approve this modification. Thank you.

@almereyda

Copy link
Copy Markdown
Contributor

Thanks, I was still wondering. Is this the original origin of the : colons we observed in the search logs and display?

@paul90

paul90 commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

I'm fairly certain that it is. The client will just use the colon terminated name as the wiki name, and the browser will silently just see that as the default port. The other likely places where the wiki name is entered by the user, such as the roster plugin, will not see it as being a wiki name as no port is specified after the :.

There are some propagation pathways in the client that I need to look at, probably just forking and twins. The reference plugin will already remove the colon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants