sanitize wiki names in lineup up#211
Open
paul90 wants to merge 1 commit into
Open
Conversation
remove any trailing ':' which create an alias pointing the wiki without the ':'
Member
|
I approve this modification. Thank you. |
Contributor
|
Thanks, I was still wondering. Is this the original origin of the |
Member
Author
|
I'm fairly certain that it is. The client will just use the colon terminated name as the wiki name, and the browser will silently just see that as the default port. The other likely places where the wiki name is entered by the user, such as the roster plugin, will not see it as being a wiki name as no port is specified after the There are some propagation pathways in the client that I need to look at, probably just forking and twins. The reference plugin will already remove the colon. |
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove any trailing
:which create an alias pointing the wiki without the:When adding a
:to the name of a wiki in the line-up the browser quietly add the default port, but the wiki-client will see it as a wiki with a name ending with a:.This becomes a problem when pages are forked, or items dragged of pages, in that wiki. The journal entry for these events will get marked with the site ending with
:.If the wiki without the trailing
:is also the neighbourhood all pages from one with be marked as having an identical twin from the other.Federation search will also see it as a separate wiki, and report it as such in recent changes. In the roster plugin, when displaying the recent activity roster,

ROSTER query.search.federatedwiki.org/recent-activity, these are see as roster categories not wiki sites.By removing the trailing
:this source that can introduce this problem.It does not address correction of any entries that have been added to a page's journal. This will be addressed in an upcoming version of the journalmatic plugin.