remove requirement for package-release.sh to be run in *.image dir#25
Open
JupiterJones wants to merge 1 commit into
Open
remove requirement for package-release.sh to be run in *.image dir#25JupiterJones wants to merge 1 commit into
JupiterJones wants to merge 1 commit into
Conversation
…he GT *.image directory Being dependent on *.image directory execution does not appear to be required by this script. The motivation to remove this requirement is so external scripts (like the one I'm writing) can build a release of gt4gemstone for a devkit stone without the requirement of having GT installed.
|
|
Author
|
I don't know if the devkit install of GT is considered a placeholder while GS gets Rowancello up to speed, and right now I just touch dummy.image to make it work from my directory, so it's not an issue. This request is only useful if these scripts are intended to be long lived, and minor things like this will just edge it cleaner. If they are not intended to be long lived, just close this request since it's not relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being dependent on *.image directory execution does not appear to be required by this script. The motivation to remove this requirement is so external scripts (like the one I'm writing) can build a release of gt4gemstone for a devkit stone without the requirement of having GT installed.