Fix checkstyle errors

Author: felfert

apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/OfferingApiLiveTest.java

@@ -58,7 +58,7 @@ public void testListDiskOfferings() throws Exception {
            assert offering.getName() != null : offering;
            assert offering.getCreated() != null : offering;
            assert offering.getDisplayText() != null : offering;
-           assert offering.getDiskSize() > 0 || (offering.getDiskSize() == 0 && offering.isCustomized()) : offering;
+           assert offering.getDiskSize() > 0 || offering.getDiskSize() == 0 && offering.isCustomized() : offering;
            assert offering.getTags() != null : offering;
 
          } catch (NoSuchElementException e) {

apis/docker/src/main/java/org/jclouds/docker/compute/options/DockerTemplateOptions.java

@@ -159,7 +159,7 @@ public boolean equals(Object o) {
     * Compares two Config.Builder instances.
     */
    private boolean buildersEqual(Config.Builder b1, Config.Builder b2) {
-      return b1 == b2 || (b1 != null && b2 != null && b1.build().equals(b2.build()));
+      return b1 == b2 || b1 != null && b2 != null && b1.build().equals(b2.build());
    }
 
    @Override

apis/docker/src/main/java/org/jclouds/docker/handlers/DockerErrorHandler.java

@@ -55,7 +55,7 @@ public void handleError(HttpCommand command, HttpResponse response) {
          switch (response.getStatusCode()) {
             case 400:
                if ((command.getCurrentRequest().getEndpoint().getPath().endsWith("/info"))
-                       || (message != null && message.indexOf("could not be found") != -1))
+                       || message != null && message.indexOf("could not be found") != -1)
                   exception = new ResourceNotFoundException(message, exception);
                else if (message != null && message.indexOf("currently in use") != -1)
                   exception = new IllegalStateException(message, exception);

apis/ec2/src/main/java/org/jclouds/ec2/binders/BindUserGroupsToIndexedFormParams.java

@@ -43,7 +43,7 @@ public <R extends HttpRequest> R bindToRequest(R request, Object input) {
    private void checkValidUserGroup(Object input) {
       Iterable<?> values = (Iterable<?>) input;
       long size = Iterables.size(values);
-      checkArgument(size == 0 || (size == 1 && Iterables.getOnlyElement(values).equals("all")),
+      checkArgument(size == 0 || size == 1 && Iterables.getOnlyElement(values).equals("all"),
             "only supported UserGroup is 'all'");
    }
 

apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java

@@ -135,7 +135,7 @@ public EC2HardwareBuilder virtualizationType(VirtualizationType virtualizationTy
       return this;
    }
 
-   public EC2HardwareBuilder virtualizationTypes(VirtualizationType ...virtualizationTypes) {
+   public EC2HardwareBuilder virtualizationTypes(VirtualizationType...virtualizationTypes) {
       Preconditions.checkNotNull(virtualizationTypes, "virtualizationTypes");
       Preconditions.checkArgument(virtualizationTypes.length > 0, "At least one virtualization type is required.");
       if (virtualizationTypes.length == 1) {

apis/elasticstack/src/main/java/org/jclouds/elasticstack/handlers/ElasticStackErrorHandler.java

@@ -56,7 +56,7 @@ public void handleError(HttpCommand command, HttpResponse response) {
          switch (response.getStatusCode()) {
          case 400:
             if ((command.getCurrentRequest().getEndpoint().getPath().endsWith("/info"))
-                  || (message != null && message.indexOf("could not be found") != -1))
+                  || message != null && message.indexOf("could not be found") != -1)
                exception = new ResourceNotFoundException(message, exception);
             else
                exception = new IllegalArgumentException(message, exception);

apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java

@@ -915,11 +915,11 @@ private String removeFileSeparatorFromBorders(String pathToBeCleaned, boolean on
 
       // search for separator chars
       if (!onlyTrailing) {
-         if (pathToBeCleaned.charAt(0) == '/' || (pathToBeCleaned.charAt(0) == '\\' && isWindows()))
+         if (pathToBeCleaned.charAt(0) == '/' || pathToBeCleaned.charAt(0) == '\\' && isWindows())
             beginIndex = 1;
       }
       if (pathToBeCleaned.charAt(pathToBeCleaned.length() - 1) == '/' ||
-            (pathToBeCleaned.charAt(pathToBeCleaned.length() - 1) == '\\' && isWindows()))
+            pathToBeCleaned.charAt(pathToBeCleaned.length() - 1) == '\\' && isWindows())
          endIndex--;
 
       return pathToBeCleaned.substring(beginIndex, endIndex);

apis/glacier/src/main/java/org/jclouds/glacier/blobstore/strategy/internal/BasePollingStrategy.java

@@ -54,12 +54,12 @@ public BasePollingStrategy(GlacierClient client) {
 
    private boolean inProgress(String job, String vault) {
       JobMetadata jobMetadata = client.describeJob(vault, job);
-      return (jobMetadata != null) && (jobMetadata.getStatusCode() == JobStatus.IN_PROGRESS);
+      return jobMetadata != null && jobMetadata.getStatusCode() == JobStatus.IN_PROGRESS;
    }
 
    private boolean succeeded(String job, String vault) {
       JobMetadata jobMetadata = client.describeJob(vault, job);
-      return (jobMetadata != null) && (jobMetadata.getStatusCode() == JobStatus.SUCCEEDED);
+      return jobMetadata != null && jobMetadata.getStatusCode() == JobStatus.SUCCEEDED;
    }
 
    @Override

apis/glacier/src/main/java/org/jclouds/glacier/domain/GlacierError.java

@@ -51,7 +51,7 @@ public String getType() {
    }
 
    public boolean isValid() {
-      return (this.code != null) && (this.message != null) && (this.type != null);
+      return this.code != null && this.message != null && this.type != null;
    }
 
    @Override

apis/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/fallbacks/EmptyFloatingIPsFallback.java

@@ -29,7 +29,7 @@
 public class EmptyFloatingIPsFallback implements Fallback<FloatingIPs> {
    @Override
    public FloatingIPs createOrPropagate(Throwable t) throws Exception {
-      if ((getFirstThrowableOfType(checkNotNull(t, "throwable"), ResourceNotFoundException.class) != null)
+      if (getFirstThrowableOfType(checkNotNull(t, "throwable"), ResourceNotFoundException.class) != null
             || contains404(t)) {
          return FloatingIPs.EMPTY;
       }