Set Content-Type to application/octet-stream for pprof format#37
Open
ishizakiyu wants to merge 1 commit into
Open
Set Content-Type to application/octet-stream for pprof format#37ishizakiyu wants to merge 1 commit into
ishizakiyu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for creating this great tool!
Problem
When fgprof is scraped by Grafana Alloy with profiling enabled,
Alloy checks the Content-Type header and expects it to start with
application/octet-stream.Since grafana/alloy#4190, responses with a different header are rejected with:
The Go standard library’s
net/http/pprofandpyroscope-goboth set:Change
Set Content-Type to
application/octet-streamwhen "format" is "pprof" (default), matching the behavior ofnet/http/pprof.