fix: djsConfig not updating because component is looking at old props#204
fix: djsConfig not updating because component is looking at old props#204wrabbit23 wants to merge 1 commit into
Conversation
| let postUrlConfigObj | ||
|
|
||
| djsConfigObj = this.props.djsConfig ? this.props.djsConfig : {} | ||
| djsConfigObj = nextProps.djsConfig ? nextProps.djsConfig : {} |
There was a problem hiding this comment.
Basically this should be like before. But there should be a strict equality comparison for the current and new config, like nextProps.djsConfig !== this.props.djsConfig.
Becuase this might not work on the initial render and it makes sense to keep the current logic to prevent any regressions.
There was a problem hiding this comment.
i don't think componentWillUpdate gets called on the initial render - although you didn't say 'mount' so maybe i'm missing something.
I could see wrapping the whole thing in that strict equality comparison to make sure this doesn't run unless either of those 2 specific props changed - for performance reasons. Is that what you're looking for?
As far as i can tell there is no reason you would ever want to run the update with the old props like it is doing today.
There was a problem hiding this comment.
I would use extend() to merge them.
I am not completely sure, also because this lifecycle method is deprecated in React 16 because of cases where it is always called.
2 participants
No description provided.