Skip to content

Commit 81b3ba2

Browse files
Changes as suggested in review
Update ci workflow with currently supported NodeJS version Add variable to catch statement Add appropriate eslint-disable directive Update ESLint config Add Node 20 to CI script Updated CI script versions
1 parent ca9d31a commit 81b3ba2

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
node-version: [12.x, 14.x, 16.x, 17.x]
16+
node-version: [20.x, 22.x, 24.x, 25.x]
1717

1818
steps:
19-
- uses: actions/checkout@v2
19+
- uses: actions/checkout@v6
2020
- name: Use Node.js ${{ matrix.node-version }}
21-
uses: actions/setup-node@v2
21+
uses: actions/setup-node@v6
2222
with:
2323
node-version: ${{ matrix.node-version }}
2424
cache: 'yarn'

eslint.config.mjs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import globals from "globals";
22
import { defineConfig } from "eslint/config";
33

44
export default defineConfig([
5-
{ files: ["**/*.{js,mjs,cjs}"], languageOptions: { globals: {...globals.browser, ...globals.node, ...globals.worker, ...globals.jest} } },
5+
{ files: ["**/*.{js,mjs,cjs}"], languageOptions: { globals: {...globals.browser, ...globals.node, ...globals.worker} } },
6+
{ files: ["test/**/*.{js,mjs,cjs}"], languageOptions: { globals: globals.jest } },
67
{
78
"rules": {
89
"indent": [
@@ -25,7 +26,8 @@ export default defineConfig([
2526
"no-unused-vars": [
2627
2,
2728
{
28-
"args": "none"
29+
"args": "none",
30+
"caughtErrors": "none"
2931
}
3032
],
3133
"semi": [

src/js.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ let custom_inspect_symbol;
8686
if (typeof process !== "undefined") {
8787
try { /* for node.js */
8888
custom_inspect_symbol = require('util').inspect.custom;
89-
} catch {}
89+
} catch (e) {}
9090
}
9191

9292
const global_env = (function(Object) {

0 commit comments

Comments
 (0)