Update files as per review

Update ci workflow with currently supported NodeJS version
Add variable to catch statements
Add appropriate eslint-disable directives
Fix ESLint config
Add Node 20.x to CI script
Remove ESLint comments
Remove ESLint from package.json
Fix shadowing of error parameter
Updated versions in CI script

Author: droberts-ctrlo

.github/workflows/ci.yaml

@@ -13,12 +13,12 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x, 17.x]
+        node-version: [20.x, 22.x, 24.x, 25.x]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v6
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v6
       with:
         node-version: ${{ matrix.node-version }}
         cache: 'yarn'

eslint.config.mjs

@@ -2,7 +2,8 @@ import globals from "globals";
 import { defineConfig } from "eslint/config";
 
 export default defineConfig([
-    { files: ["**/*.{js,mjs,cjs}"], languageOptions: { globals: { ...globals.browser, ...globals.node, ...globals.worker, ...globals.jest } } },
+    { files: ["**/*.{js,mjs,cjs}"], languageOptions: { globals: { ...globals.browser, ...globals.node, ...globals.worker } } },
+    { files: ["test/**/*.{js,mjs,cjs}"], languageOptions: { globals: globals.jest } },
     {
         "rules": {
             "indent": [
@@ -26,7 +27,8 @@ export default defineConfig([
             "no-unused-vars": [
                 2,
                 {
-                    "args": "none"
+                    "args": "none",
+                    "caughtErrors": "none"
                 }
             ],
             "semi": [

package.json

@@ -38,54 +38,5 @@
     "sprintf-js": "^1.1.3",
     "tmp": "^0.2.5"
   },
-  "sideEffects": false,
-  "eslintConfig": {
-    "env": {
-      "browser": true,
-      "es6": true,
-      "node": true,
-      "worker": true
-    },
-    "extends": "eslint:recommended",
-    "rules": {
-      "indent": [
-        "error",
-        4,
-        {
-          "SwitchCase": 1
-        }
-      ],
-      "linebreak-style": [
-        "error",
-        "unix"
-      ],
-      "no-console": 0,
-      "no-empty": [
-        2,
-        {
-          "allowEmptyCatch": true
-        }
-      ],
-      "no-unused-vars": [
-        2,
-        {
-          "args": "none"
-        }
-      ],
-      "semi": [
-        "error",
-        "always"
-      ]
-    },
-    "overrides": [
-      {
-        "files": [
-          "test/**/*.test.js"
-        ],
-        "env": {
-          "jest": true
-        }
-      }
-    ]
-  }
+  "sideEffects": false
 }

src/lauxlib.js

@@ -968,7 +968,7 @@ if (typeof process === "undefined") {
             lf.buff[lf.n++] = com.c; /* 'c' is the first character of the stream */
         let status = lua_load(L, getF, lf, lua_tostring(L, -1), mode);
         let readstatus = lf.err;
-        if (filename) try { fs.closeSync(lf.f); } catch {}  /* close file (even in case of errors) */
+        if (filename) try { fs.closeSync(lf.f); } catch (e) {}  /* close file (even in case of errors) */
         if (readstatus) {
             lua_settop(L, fnameindex);  /* ignore results from 'lua_load' */
             return errfile(L, "read", fnameindex, readstatus);

src/lbaselib.js

@@ -97,7 +97,7 @@ if (typeof process === "undefined") {
             try {
                 /* If the string is valid utf8, then we can use to_jsstring */
                 s = to_jsstring(s);
-            } catch {
+            } catch (e) {
                 /* otherwise push copy of raw array */
                 let copy = new Uint8Array(s.length);
                 copy.set(s);
@@ -269,7 +269,7 @@ const luaB_ipairs = function(L) {
 const b_str2int = function(s, base) {
     try {
         s = to_jsstring(s);
-    } catch {
+    } catch (e) {
         return null;
     }
     let r = /^[\t\v\f \n\r]*([+-]?)0*([0-9A-Za-z]+)[\t\v\f \n\r]*$/.exec(s);

src/ldo.js

@@ -424,7 +424,7 @@ const luaD_rawrunprotected = function(L, f, ud) {
                     }
 
                     lj.status = LUA_ERRRUN;
-                } catch {
+                } catch (e2) {
                     if (lj.status === LUA_OK) {
                         /* also failed */
                         lj.status = -1;

src/loadlib.js

@@ -202,7 +202,7 @@ if (typeof process !== "undefined") { // Only with Node
         try {
             let fd = fs.openSync(filename, 'r');
             fs.closeSync(fd);
-        } catch {
+        } catch (e) {
             return false;
         }
         return true;

src/lobject.js

@@ -478,7 +478,7 @@ const lua_strx2number = function(s) {
 const lua_str2number = function(s) {
     try {
         s = to_jsstring(s);
-    } catch {
+    } catch (e) {
         return null;
     }
     /* use a regex to validate number and also to get length

test/test-suite/ltests.js

@@ -691,7 +691,7 @@ const checkpanic = function(L) {
     try {    /* set jump buffer */
         runJS(L, L1, { script: code, offset: 0 });    /* run code unprotected */
         lua.lua_pushliteral(L, "no errors");
-    } catch {    /* error handling */
+    } catch (e) {    /* error handling */
         /* move error message to original state */
         lua.lua_pushstring(L, lua.lua_tostring(L1, -1));
     }