add CLI checks and fix cross-SDK workflow issues (opensandbox-group#569)

* test(sdks): update quality

* feat(cli): ruff check fix

* feat(cli): pyright check fix

* chore(workflow): cli quality workflow

* chore(cli): refine packaging

* test(sdks): fix tests

Author: ninan-nn

.github/workflows/sdk-tests.yml

@@ -18,12 +18,14 @@ on:
   pull_request:
     branches: [main]
     paths:
+      - "cli/**"
       - "sdks/sandbox/**"
       - "sdks/code-interpreter/**"
       - "specs/**"
   push:
     branches: [main]
     paths:
+      - "cli/**"
       - "sdks/sandbox/**"
       - "sdks/code-interpreter/**"
       - "specs/**"
@@ -36,6 +38,74 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  cli-quality:
+    name: CLI Quality
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Set up Python
+        uses: actions/setup-python@v6
+        with:
+          python-version: "3.11"
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v7
+        with:
+          version: "latest"
+
+      - name: Install dependencies
+        working-directory: cli
+        run: |
+          uv sync
+
+      - name: Run ruff
+        working-directory: cli
+        run: |
+          uv run ruff check
+
+      - name: Run pyright
+        working-directory: cli
+        run: |
+          uv run pyright
+
+  cli-tests:
+    name: CLI Tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Set up Python
+        uses: actions/setup-python@v6
+        with:
+          python-version: "3.11"
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v7
+        with:
+          version: "latest"
+
+      - name: Install dependencies
+        working-directory: cli
+        run: |
+          uv sync
+
+      - name: Run tests
+        working-directory: cli
+        run: |
+          mkdir -p reports
+          uv run pytest tests/ -v --junitxml=reports/junit.xml
+
+      - name: Upload CLI reports
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: cli-reports
+          path: |
+            cli/reports/**
+
   python-sdk-quality:
     name: Python SDK Quality (${{ matrix.package_name }})
     runs-on: ubuntu-latest
@@ -82,9 +152,19 @@ jobs:
         run: |
           uv run pyright
 
-  python-sdk:
-    name: Python SDK Tests
+  python-sdk-tests:
+    name: Python SDK Tests (${{ matrix.package_name }})
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - package_name: sandbox
+            package_dir: sdks/sandbox/python
+            coverage_target: src/opensandbox
+          - package_name: code-interpreter
+            package_dir: sdks/code-interpreter/python
+            coverage_target: src/code_interpreter
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
@@ -99,20 +179,112 @@ jobs:
         with:
           version: "latest"
 
+      - name: Install dependencies
+        working-directory: ${{ matrix.package_dir }}
+        run: |
+          uv sync
+
       - name: Generate API
+        if: matrix.package_name == 'sandbox'
         working-directory: sdks/sandbox/python
         run: |
-          uv sync
           uv run python scripts/generate_api.py
 
       - name: Run tests
-        working-directory: sdks/sandbox/python
+        working-directory: ${{ matrix.package_dir }}
+        run: |
+          mkdir -p reports
+          uv run pytest tests/ -v \
+            --junitxml=reports/junit.xml \
+            --cov=${{ matrix.coverage_target }} \
+            --cov-report=term-missing \
+            --cov-report=xml:reports/coverage.xml
+
+      - name: Upload Python reports
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: python-${{ matrix.package_name }}-reports
+          path: |
+            ${{ matrix.package_dir }}/reports/**
+
+  javascript-sdk-quality:
+    name: JavaScript SDK Quality And Tests (${{ matrix.package_name }})
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - package_name: sandbox
+            package_dir: sdks/sandbox/javascript
+          - package_name: code-interpreter
+            package_dir: sdks/code-interpreter/javascript
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Set up pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 9.15.0
+          run_install: false
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "pnpm"
+          cache-dependency-path: sdks/pnpm-lock.yaml
+
+      - name: Install dependencies
+        working-directory: sdks
+        run: |
+          pnpm install --frozen-lockfile
+
+      - name: Build JavaScript SDK dependencies
+        working-directory: sdks
+        run: |
+          pnpm run build:js
+
+      - name: Run eslint
+        working-directory: ${{ matrix.package_dir }}
         run: |
-          uv run pytest tests/ -v
+          pnpm run lint
 
-  kotlin-sdk:
-    name: Kotlin SDK Tests
+      - name: Run TypeScript typecheck
+        working-directory: ${{ matrix.package_dir }}
+        run: |
+          pnpm run typecheck
+
+      - name: Run tests
+        working-directory: ${{ matrix.package_dir }}
+        run: |
+          mkdir -p reports
+          node --test tests/*.test.mjs > reports/test-output.txt
+
+      - name: Upload JavaScript reports
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: javascript-${{ matrix.package_name }}-reports
+          path: |
+            ${{ matrix.package_dir }}/reports/**
+
+  kotlin-sdk-quality:
+    name: Kotlin SDK Quality And Tests (${{ matrix.package_name }})
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - package_name: sandbox
+            package_dir: sdks/sandbox/kotlin
+            test_task: :sandbox:test
+            gradle_args: ""
+          - package_name: code-interpreter
+            package_dir: sdks/code-interpreter/kotlin
+            test_task: :code-interpreter:test
+            gradle_args: "-PuseMavenLocal"
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
@@ -126,14 +298,41 @@ jobs:
       - name: Set up Gradle
         uses: gradle/actions/setup-gradle@v5
 
-      - name: Run tests
+      - name: Publish sandbox SDK to Maven local
+        if: matrix.package_name == 'code-interpreter'
         working-directory: sdks/sandbox/kotlin
         run: |
-          ./gradlew :sandbox:test
+          ./gradlew publishToMavenLocal
 
-  csharp-sdk:
-    name: C# SDK Tests
+      - name: Run quality checks and tests
+        working-directory: ${{ matrix.package_dir }}
+        run: |
+          ./gradlew spotlessCheck ${{ matrix.test_task }} ${{ matrix.gradle_args }}
+
+      - name: Upload Kotlin reports
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: kotlin-${{ matrix.package_name }}-reports
+          path: |
+            ${{ matrix.package_dir }}/**/build/test-results/test/**
+            ${{ matrix.package_dir }}/**/build/reports/tests/test/**
+
+  csharp-sdk-quality:
+    name: C# SDK Quality And Tests (${{ matrix.package_name }})
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - package_name: sandbox
+            package_dir: sdks/sandbox/csharp
+            solution: OpenSandbox.sln
+            test_project: tests/OpenSandbox.Tests/OpenSandbox.Tests.csproj
+          - package_name: code-interpreter
+            package_dir: sdks/code-interpreter/csharp
+            solution: OpenSandbox.CodeInterpreter.sln
+            test_project: tests/OpenSandbox.CodeInterpreter.Tests/OpenSandbox.CodeInterpreter.Tests.csproj
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
@@ -143,12 +342,25 @@ jobs:
         with:
           dotnet-version: "10.0.x"
 
-      - name: Run sandbox tests
-        working-directory: sdks/sandbox/csharp
+      - name: Build with analyzers
+        working-directory: ${{ matrix.package_dir }}
         run: |
-          dotnet test tests/OpenSandbox.Tests/OpenSandbox.Tests.csproj --configuration Release
+          dotnet build ${{ matrix.solution }} --configuration Release /warnaserror
 
-      - name: Run code interpreter tests
-        working-directory: sdks/code-interpreter/csharp
+      - name: Run tests with reports
+        working-directory: ${{ matrix.package_dir }}
         run: |
-          dotnet test tests/OpenSandbox.CodeInterpreter.Tests/OpenSandbox.CodeInterpreter.Tests.csproj --configuration Release
+          dotnet test ${{ matrix.test_project }} \
+            --configuration Release \
+            --no-build \
+            --logger "trx;LogFileName=test-results.trx" \
+            --results-directory TestResults \
+            --collect:"XPlat Code Coverage"
+
+      - name: Upload C# reports
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: csharp-${{ matrix.package_name }}-reports
+          path: |
+            ${{ matrix.package_dir }}/TestResults/**

cli/README.md

@@ -13,7 +13,7 @@ pip install opensandbox-cli
 ### uv
 
 ```bash
-uv add opensandbox-cli
+uv tool install opensandbox-cli
 ```
 
 ### pipx (recommended for global CLI usage)
@@ -46,7 +46,8 @@ opensandbox-server
 
 ```bash
 cd cli
-uv pip install -e .
+uv sync
+uv run osb --help
 ```
 
 ![Install CLI](assets/install_cli.png)
@@ -205,6 +206,18 @@ The CLI resolves configuration from multiple sources with the following priority
 3. **Config file** — `~/.opensandbox/config.toml` (or path specified via `--config`)
 4. **SDK defaults**
 
+## Development
+
+For local CLI development in this monorepo, prefer `uv sync` from the `cli/` directory. That workflow honors the local `[tool.uv.sources]` overrides for `opensandbox` and `opensandbox-code-interpreter`, so the CLI resolves against the checked-out SDKs instead of published packages.
+
+```bash
+cd cli
+uv sync
+uv run osb --help
+```
+
+If you specifically need an editable install into another environment, install the SDK dependencies from their local paths first, then install the CLI.
+
 ### Config File Format
 
 ```toml

cli/pyproject.toml

@@ -39,6 +39,7 @@ classifiers = [
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.13",
     "Topic :: Software Development :: Libraries",
+    "Typing :: Typed",
 ]
 dependencies = [
     "opensandbox>=0.1.4,<0.2.0",

cli/src/opensandbox_cli/client.py

@@ -22,7 +22,6 @@
 from typing import Any
 
 import click
-
 from opensandbox.config.connection_sync import ConnectionConfigSync
 from opensandbox.models.sandboxes import SandboxFilter
 from opensandbox.sync.manager import SandboxManagerSync

cli/src/opensandbox_cli/commands/code.py

@@ -19,7 +19,6 @@
 import sys
 
 import click
-
 from opensandbox.models.execd import OutputMessage
 from opensandbox.models.execd_sync import ExecutionHandlersSync
 
@@ -54,10 +53,11 @@ def code_run(
     """Execute code in a sandbox."""
     from code_interpreter.sync.code_interpreter import CodeInterpreterSync
 
-    if code is None:
+    source_code = code
+    if source_code is None:
         if sys.stdin.isatty():
             click.echo("Reading code from stdin (Ctrl+D to finish):", err=True)
-        code = sys.stdin.read()
+        source_code = sys.stdin.read()
 
     sandbox = obj.connect_sandbox(sandbox_id)
     try:
@@ -78,7 +78,7 @@ def on_stderr(msg: OutputMessage) -> None:
 
         handlers = ExecutionHandlersSync(on_stdout=on_stdout, on_stderr=on_stderr)
         execution = interpreter.codes.run(
-            code, language=language, handlers=handlers, **kwargs
+            source_code, language=language, handlers=handlers, **kwargs
         )
 
         if execution.error: