chore(deps): bump vite-plus to 0.1.21-alpha.7#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of vite, vite-plus, and vitest to 0.1.21-alpha.7 across the main frontend and multiple widget packages. It also introduces pnpm-workspace.yaml files to exclude these packages from minimum release age checks. The reviewer suggests centralizing the workspace configuration at the repository root to reduce duplication and improve maintainability. Additionally, it is recommended to include vite-plus in the overrides section of the package.json files to ensure version consistency throughout the dependency tree.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
Since you are bumping vite-plus to an alpha version and overriding its core components (vite and vitest), it is recommended to also include vite-plus in the overrides section. This ensures that any transitive dependencies or other packages in the tree that might depend on vite-plus are forced to use the same alpha version, maintaining consistency across the project.
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7",
"vite-plus": "0.1.21-alpha.7",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7"| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The addition of identical pnpm-workspace.yaml files across multiple subdirectories (src/frontend, src/widgets/...) suggests a fragmented workspace setup. If these projects are part of a single monorepo, it would be much more maintainable to have a single pnpm-workspace.yaml at the repository root. This would allow you to centralize configurations like minimumReleaseAgeExclude and leverage pnpm catalogs (which you mentioned in the PR description) to manage shared dependency versions centrally instead of repeating them in every package.json.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan