chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates core build and linting dependencies, including Vite and Vitest, to specific preview versions across the frontend and multiple widget packages. It also introduces .npmrc configurations to manage package release age. Feedback identifies redundant .npmrc files at the root of the ScreenshotFeedback and Tiptap widgets that should be removed. Additionally, it is recommended to include the virtual-store-dir-max-length setting in all new .npmrc files to maintain consistency and prevent long path issues on Windows.
| min-release-age=259200 | ||
| min-release-age-exclude=vite-plus,@voidzero-dev/* |
There was a problem hiding this comment.
This .npmrc file at the widget root is redundant and inconsistent with other widgets in the repository. The same configuration is already being added to src/widgets/Ivy.Widgets.ScreenshotFeedback/frontend/.npmrc, which is the correct location as it aligns with the package.json and lockfile. Please remove this file.
| min-release-age=259200 | ||
| min-release-age-exclude=vite-plus,@voidzero-dev/* |
| min-release-age=259200 | ||
| min-release-age-exclude=vite-plus,@voidzero-dev/* |
There was a problem hiding this comment.
For consistency with other widgets in the repository (e.g., ClaudeJsonRenderer, DiffView, ScreenshotFeedback), consider adding virtual-store-dir-max-length=15 to this .npmrc file. This setting is used across several widgets to prevent long path issues on Windows. This also applies to the new .npmrc files in AgentOutputView, AnimatedStatusLabel, Leaflet, and QRCode.
virtual-store-dir-max-length=15
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan