Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4

Draft
fengmk2 wants to merge 1 commit into
developmentfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
fengmk2 wants to merge 1 commit into
developmentfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 19, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates core build and linting dependencies, including Vite and Vitest, to specific preview versions across the frontend and multiple widget packages. It also introduces .npmrc configurations to manage package release age. Feedback identifies redundant .npmrc files at the root of the ScreenshotFeedback and Tiptap widgets that should be removed. Additionally, it is recommended to include the virtual-store-dir-max-length setting in all new .npmrc files to maintain consistency and prevent long path issues on Windows.

Comment on lines +1 to +2
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This .npmrc file at the widget root is redundant and inconsistent with other widgets in the repository. The same configuration is already being added to src/widgets/Ivy.Widgets.ScreenshotFeedback/frontend/.npmrc, which is the correct location as it aligns with the package.json and lockfile. Please remove this file.

Comment on lines +1 to +2
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This .npmrc file at the widget root is redundant because the configuration is already present in src/widgets/Ivy.Widgets.Tiptap/frontend/.npmrc. It should be removed to maintain consistency with the project structure.

Comment on lines +1 to +2
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other widgets in the repository (e.g., ClaudeJsonRenderer, DiffView, ScreenshotFeedback), consider adding virtual-store-dir-max-length=15 to this .npmrc file. This setting is used across several widgets to prevent long path issues on Windows. This also applies to the new .npmrc files in AgentOutputView, AnimatedStatusLabel, Leaflet, and QRCode.

virtual-store-dir-max-length=15
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant