vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates test imports from vitest to vite-plus/test, updates dependencies to use @voidzero-dev/vite-plus-core, configures pre-commit hooks, and adds a wildcard module declaration for Vue files. Feedback includes removing the unused vitest dependency from packages/anywidget/package.json and using any instead of unknown in the Vue declaration file to avoid overly restrictive types.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "@jupyter-widgets/base-manager": "^1.0.12", | ||
| "vitest": "4.1.9" |
There was a problem hiding this comment.
| @@ -0,0 +1,5 @@ | |||
| declare module "*.vue" { | |||
| import type { DefineComponent } from "vue"; | |||
| const component: DefineComponent<{}, {}, unknown>; | |||
There was a problem hiding this comment.
Using unknown as the third generic argument (D / Data) for DefineComponent can be overly restrictive for a general wildcard module declaration, as it might force consumers to cast or handle unknown types when accessing component instance data. Using any is more standard for wildcard shims to ensure smooth integration.
| const component: DefineComponent<{}, {}, unknown>; | |
| const component: DefineComponent<{}, {}, any>; |
No description provided.