Skip to content

vp migrate beta test#9

Draft
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#9
fengmk2 wants to merge 1 commit into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 28, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates test imports from vitest to vite-plus/test, updates dependencies to use @voidzero-dev/vite-plus-core, configures pre-commit hooks, and adds a wildcard module declaration for Vue files. Feedback includes removing the unused vitest dependency from packages/anywidget/package.json and using any instead of unknown in the Vue declaration file to avoid overly restrictive types.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +30 to +31
"@jupyter-widgets/base-manager": "^1.0.12",
"vitest": "4.1.9"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the imports in packages/anywidget/__tests__/widget.test.ts have been migrated from vitest to vite-plus/test, vitest is no longer directly imported in this package. Consider removing vitest from devDependencies to avoid unused dependencies.

    "@jupyter-widgets/base-manager": "^1.0.12"

Comment thread packages/vue/env.d.ts
@@ -0,0 +1,5 @@
declare module "*.vue" {
import type { DefineComponent } from "vue";
const component: DefineComponent<{}, {}, unknown>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using unknown as the third generic argument (D / Data) for DefineComponent can be overly restrictive for a general wildcard module declaration, as it might force consumers to cast or handle unknown types when accessing component instance data. Using any is more standard for wildcard shims to ensure smooth integration.

Suggested change
const component: DefineComponent<{}, {}, unknown>;
const component: DefineComponent<{}, {}, any>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant