Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588 #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e26a313
chore(deps): bump vite-plus to pkg-pr-new pr-1588
fengmk2 May 28, 2026
6dfcfc2
chore(deps): refresh lockfile after vite-plus pkg-pr-new pr-1588 bump
fengmk2 May 28, 2026
55c4069
chore(deps): move pnpm.overrides to pnpm-workspace.yaml so pnpm 10+ a…
fengmk2 May 28, 2026
748ce74
chore(deps): remove unused vitest devDep (project uses vite-plus/test)
fengmk2 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
"devDependencies": {
"@vitest/coverage-v8": "4.1.5",
"release-it": "20.0.1",
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.16",
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588",
"vite-plugin-dts": "4.5.4",
"vite-plus": "0.1.19",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.16",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588",
"vitest": "^4.1.5",
"webdriverio": "9.27.0"
},
"engines": {
Expand All @@ -60,8 +60,8 @@
"packageManager": "pnpm@10.33.0",
"pnpm": {
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.16",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.16"
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e"

@gemini-code-assist gemini-code-assist Bot May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There are two issues with the current overrides configuration:

  1. Inconsistent Version Specifiers: The devDependencies (lines 51 and 53) use the PR specifier @1588, whereas the overrides here use a specific commit hash (@5577b0154f33d1480a3c96347e94fa5d2094de2e). This inconsistency can lead to multiple versions of the same package being resolved and cached, and it prevents automatic updates when new commits are pushed to PR 1588.
  2. Missing vite Override: In the original configuration, "vite" was overridden to "npm:@voidzero-dev/vite-plus-core@0.1.16". Removing this override means that any transitive dependencies (such as vite-plugin-dts) requiring "vite" will now resolve to the official vite package from npm instead of the custom core. This can lead to duplicate installations of Vite and potential runtime/build issues.

To fix this, we should restore the "vite" override and use the consistent @1588 specifier for all overrides.

			"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588",
			"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588",
			"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@1588"

}
}
}
12 changes: 12 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
blockExoticSubdeps: false
minimumReleaseAge: 60
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
- "@oxc-project/*"
- "@oxlint/*"
- oxlint
- oxfmt
- oxlint-tsgolint
- vitest
- "@vitest/*"
Loading