Skip to content

chore: upgrade vite-plus to 0.2.1#25

Draft
fengmk2 wants to merge 2 commits into
mainfrom
chore/upgrade-vite-plus-0.2.1
Draft

chore: upgrade vite-plus to 0.2.1#25
fengmk2 wants to merge 2 commits into
mainfrom
chore/upgrade-vite-plus-0.2.1

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Problem

Upgrade Vite+ (vp) from v0.1.x to v0.2.1. v0.2.1 consumes upstream Vitest directly: the @voidzero-dev/vite-plus-test wrapper is removed and vitest now comes in transitively through vite-plus.

Changes

  • vite-plus: 0.1.20 -> 0.2.1
  • vite override -> npm:@voidzero-dev/vite-plus-core@0.2.1 (still required, kept in lockstep)
  • This project uses vitest directly (test files import vitest, plus the @vitest/coverage-v8 provider), so upstream vitest is pinned to the bundled 4.1.9:
    • vitest: wrapper alias -> 4.1.9
    • @vitest/coverage-v8: 4.1.6 -> 4.1.9
    • add @vitest/browser-playwright@4.1.9 (now an optional peer of vite-plus, needed by the nuxt browser test project)
  • Drop the wrapper-based vitest override from pnpm-workspace.yaml
  • Fix two vue/no-dupe-keys errors newly surfaced by the bundled oxlint 1.70 (import names that shadowed prop names), via internal import aliases. Behaviour unchanged.

Verification

  • No @voidzero-dev/vite-plus-test reference remains outside node_modules
  • Dependency tree resolves to a single vitest@4.1.9 (no duplicate copies)
  • vp test: 135 files, 2724 passed / 5 skipped (native RUN v4.1.9 banner)
  • vp check: passes (0 errors)

fengmk2 added 2 commits June 18, 2026 16:52
v0.2.1 consumes upstream Vitest directly, so the
@voidzero-dev/vite-plus-test wrapper is removed and vitest now comes in
transitively through vite-plus.

- vite-plus: 0.1.20 -> 0.2.1
- vite override -> npm:@voidzero-dev/vite-plus-core@0.2.1
- pin upstream vitest 4.1.9 (was the wrapper alias) and bump
  @vitest/coverage-v8 to 4.1.9
- add @vitest/browser-playwright 4.1.9, now an optional peer of
  vite-plus, used by the nuxt browser test project
- drop the wrapper-based vitest override
oxlint 1.70 (bundled in vite-plus 0.2.1) flags import names that collide
with prop names. Alias the internal imports so they no longer shadow the
public prop names; behaviour is unchanged.

- Input/Base.vue: noCorrect/noPasswordManager imports -> *Attrs aliases
- Tooltip/Base.vue: offset middleware import -> offsetMiddleware
@fengmk2 fengmk2 marked this pull request as draft June 18, 2026 08:56

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors imports in the Input and Tooltip base components to use clearer aliases (such as 'noCorrectAttrs', 'noPasswordManagerAttrs', and 'offsetMiddleware') to avoid naming conflicts. Additionally, it updates project dependencies, upgrading 'vite-plus' to '0.2.1', reverting 'vitest' from a custom fork to the official '4.1.9' release, and adding '@vitest/browser-playwright'. Lockfile and workspace configurations have been updated accordingly. There are no review comments to address, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@@ -1,5 +1,8 @@
<script setup lang="ts">
import { noCorrect, noPasswordManager } from '~/utils/input'

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

× [vue(no-dupe-keys)](https://oxc.rs/docs/guide/usage/linter/rules/vue/no-dupe-keys.html): Duplicate key 'noCorrect'. May cause name collision in script or template tag.
   ╭─[app/components/Input/Base.vue:2:10]
 1 │ <script setup lang="ts">
 2 │ import { noCorrect, noPasswordManager } from '~/utils/input'
   ·          ─────────
 3 │
   ╰────

  × [vue(no-dupe-keys)](https://oxc.rs/docs/guide/usage/linter/rules/vue/no-dupe-keys.html): Duplicate key 'noPasswordManager'. May cause name collision in script or template tag.
   ╭─[app/components/Input/Base.vue:2:21]
 1 │ <script setup lang="ts">
 2 │ import { noCorrect, noPasswordManager } from '~/utils/input'
   ·                     ─────────────────
 3 │
   ╰────

import type { HTMLAttributes } from 'vue'
import type { Placement, Strategy } from '@floating-ui/vue'
import { autoUpdate, flip, offset, shift, useFloating } from '@floating-ui/vue'
import { autoUpdate, flip, offset as offsetMiddleware, shift, useFloating } from '@floating-ui/vue'

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

× [vue(no-dupe-keys)](https://oxc.rs/docs/guide/usage/linter/rules/vue/no-dupe-keys.html): Duplicate key 'offset'. May cause name collision in script or template tag.
   ╭─[app/components/Tooltip/Base.vue:4:28]
 3 │ import type { Placement, Strategy } from '@floating-ui/vue'
 4 │ import { autoUpdate, flip, offset, shift, useFloating } from '@floating-ui/vue'
   ·                            ──────
 5 │
   ╰────

@github-actions

Copy link
Copy Markdown

📊 Dependency Size Changes

Warning

This PR adds 12.1 MB of new dependencies, which exceeds the threshold of 200 kB.

📦 Package 📏 Size
@oxlint/binding-linux-x64-gnu@1.61.0 → @oxlint/binding-linux-x64-gnu@1.70.0 7 MB
@voidzero-dev/vite-plus-test@0.1.20 -6.7 MB
@voidzero-dev/vite-plus-linux-x64-gnu@0.1.20 → @voidzero-dev/vite-plus-linux-x64-gnu@0.2.1 5.3 MB
vitest@4.1.9 1.9 MB
@vitest/browser@4.1.9 1.8 MB
oxlint@1.61.0 → oxlint@1.70.0 842.5 kB
@oxlint-tsgolint/linux-x64@0.22.0 → @oxlint-tsgolint/linux-x64@0.23.0 572.2 kB
vite-plus@0.1.20 → vite-plus@0.2.1 460.2 kB
@oxfmt/binding-linux-x64-gnu@0.46.0 → @oxfmt/binding-linux-x64-gnu@0.55.0 -274.4 kB
oxfmt@0.46.0 → oxfmt@0.55.0 239.2 kB
@oxlint/plugins@1.68.0 195.5 kB
@vitest/runner@4.1.9 193.9 kB
@vitest/mocker@4.1.9 187.4 kB
chai@6.2.2 146.6 kB
expect-type@1.3.0 119.8 kB
@vitest/expect@4.1.9 106.8 kB
es-module-lexer@1.7.0 -93.4 kB
@vitest/snapshot@4.1.9 59.3 kB
@vitest/browser-playwright@4.1.9 48.6 kB
@voidzero-dev/vite-plus-core@0.1.20 → @voidzero-dev/vite-plus-core@0.2.1 38.8 kB
@vitest/spy@4.1.9 37.4 kB
@blazediff/core@1.9.1 21.6 kB
pixelmatch@7.1.0 -19.4 kB
@vitest/browser-preview@4.1.9 12.9 kB
why-is-node-running@2.3.0 7.3 kB
siginfo@2.0.0 4.8 kB
@vitest/coverage-v8@4.1.6 → @vitest/coverage-v8@4.1.9 -20 B
vite@@voidzero-dev/vite-plus-core@0.2.1 Unknown
vite@@voidzero-dev/vite-plus-core@0.1.20 Unknown
@vitest/utils@4.1.6 → @vitest/utils@4.1.9 0 B
@vitest/pretty-format@4.1.6 → @vitest/pretty-format@4.1.9 0 B
@oxc-project/runtime@0.127.0 → @oxc-project/runtime@0.136.0 0 B
@oxc-project/types@0.127.0 → @oxc-project/types@0.136.0 0 B
oxlint-tsgolint@0.22.0 → oxlint-tsgolint@0.23.0 0 B
stackback@0.0.2 Unknown
vitest@@voidzero-dev/vite-plus-test@0.1.20 Unknown

Total size change: 12.1 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant