Skip to content

Added secure connection with certificate#13

Open
dyohan9 wants to merge 1 commit into
fengsp:masterfrom
dyohan9:feature/secure-certificate
Open

Added secure connection with certificate#13
dyohan9 wants to merge 1 commit into
fengsp:masterfrom
dyohan9:feature/secure-certificate

Conversation

@dyohan9

@dyohan9 dyohan9 commented Mar 12, 2021

Copy link
Copy Markdown

This will allow the grpc server to also be able to run using certificates making the client's connection to the server secure.

#2
#12

@dyohan9

dyohan9 commented Mar 19, 2021

Copy link
Copy Markdown
Author

hello, could you review? @fengsp

@dyohan9

dyohan9 commented Aug 4, 2021

Copy link
Copy Markdown
Author

Hi @fengsp, could you review?

@fengsp

fengsp commented Aug 21, 2021

Copy link
Copy Markdown
Owner

@dyohan9 Adding secure connection support is good 👍 . I might use grpc_settings to set up this, just like interceptors config, so that we have more flexibility, we have grpc.ssl_server_credentials and grpc.dynamic_ssl_server_credentials, so we could let users config one ServerCredentials instance in grpc_settings and use it, now users can choose whatever method to create a ServerCredentials. Any better idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants