Fix memory leak introduced on the screenshare feature#2073
Merged
Conversation
Alphrag
reviewed
Mar 11, 2025
SpecialAro
force-pushed
the
fix-memory-leak
branch
from
287ae9b to
557e25f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Fix memory leak introduced on the screenshare feature
Motivation and Context
This (possibly) fixes #2065. Amongs other changes, I've added (ported from #2067) some code to improve some listeners that were not being removed - possibly causing memory leaks.
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
Fixed a memory leak introduced by the screenshare feature