refactor(cli): remove LoggableFernCliError in favor of CliError

Replace all LoggableFernCliError throw sites with CliError.internalError()
and remove the dedicated catch branches since CliError is already handled
upstream. Deletes the now-unused LoggableFernCliError class.

Made-with: Cursor

Author: FedeZara

packages/cli/cli/src/cli.ts

@@ -33,7 +33,7 @@ import {
 import { LOG_LEVELS, LogLevel } from "@fern-api/logger";
 import { askToLogin, login, logout } from "@fern-api/login";
 import { protocGenFern } from "@fern-api/protoc-gen-fern";
-import { CliError, LoggableFernCliError, TaskAbortSignal } from "@fern-api/task-context";
+import { CliError, TaskAbortSignal } from "@fern-api/task-context";
 import getPort from "get-port";
 import { Argv } from "yargs";
 import { hideBin } from "yargs/helpers";
@@ -145,8 +145,6 @@ async function runCli() {
             cliContext.failWithoutThrowing(undefined, error, { code: "ENVIRONMENT_ERROR" });
         } else if (error instanceof TaskAbortSignal) {
             cliContext.failWithoutThrowing();
-        } else if (error instanceof LoggableFernCliError) {
-            cliContext.logger.error(`Failed. ${error.log}`);
         } else {
             cliContext.failWithoutThrowing("Failed.", error, { code: "INTERNAL_ERROR" });
         }

packages/cli/generation/ir-generator/src/extended-properties/addExtendedPropertiesToIr.ts

@@ -6,7 +6,7 @@ import {
     ObjectTypeDeclaration,
     TypeDeclaration
 } from "@fern-api/ir-sdk";
-import { LoggableFernCliError } from "@fern-api/task-context";
+import { CliError } from "@fern-api/task-context";
 
 import { getTypeDeclaration } from "../utils/getTypeDeclaration.js";
 
@@ -96,9 +96,7 @@ function getObjectTypeDeclarationFromTypeId(typeId: string, ir: TypesAndServices
         }
     }
 
-    throw new LoggableFernCliError(
-        `Unexpected error: ${typeId} is extended but has shape ${typeDeclaration.shape.type}`
-    );
+    throw CliError.internalError(`Unexpected error: ${typeId} is extended but has shape ${typeDeclaration.shape.type}`);
 }
 
 function getAllPropertiesForObject({

packages/cli/generation/ir-generator/src/utils/getTypeDeclaration.ts

@@ -1,10 +1,10 @@
 import { TypeDeclaration } from "@fern-api/ir-sdk";
-import { LoggableFernCliError } from "@fern-api/task-context";
+import { CliError } from "@fern-api/task-context";
 
 export function getTypeDeclaration(typeId: string, types: Record<string, TypeDeclaration>): TypeDeclaration {
     const maybeTypeDeclaration = types[typeId];
     if (maybeTypeDeclaration == null) {
-        throw new LoggableFernCliError(`Illegal Error: Failed to load type declaration for type ${typeId}`);
+        throw CliError.internalError(`Failed to load type declaration for type ${typeId}`);
     }
     return maybeTypeDeclaration;
 }

packages/cli/generation/local-generation/local-workspace-runner/src/GenerationRunner.ts

@@ -4,7 +4,7 @@ import { generatorsYml, SNIPPET_JSON_FILENAME } from "@fern-api/configuration";
 import { AbsoluteFilePath, join, RelativeFilePath } from "@fern-api/fs-utils";
 import { generateIntermediateRepresentation } from "@fern-api/ir-generator";
 import { IntermediateRepresentation } from "@fern-api/ir-sdk";
-import { LoggableFernCliError, TaskAbortSignal, TaskContext } from "@fern-api/task-context";
+import { TaskAbortSignal, TaskContext } from "@fern-api/task-context";
 import { FernGeneratorExec } from "@fern-fern/generator-exec-sdk";
 import chalk from "chalk";
 import { generateDynamicSnippetTests } from "./dynamic-snippets/generateDynamicSnippetTests.js";
@@ -101,8 +101,6 @@ export class GenerationRunner {
                         } catch (error) {
                             if (error instanceof TaskAbortSignal) {
                                 // already logged by failAndThrow, nothing to do
-                            } else if (error instanceof LoggableFernCliError) {
-                                interactiveTaskContext.failWithoutThrowing(`Generation failed: ${error.log}`, error);
                             } else {
                                 interactiveTaskContext.failWithoutThrowing(
                                     `Generation failed: ${error instanceof Error ? error.message : "Unknown error"}`,

packages/cli/task-context/src/LoggableFernCliError.ts

@@ -1,5 +1,4 @@
 export { CliError, resolveErrorCode, shouldReportToSentry } from "./CliError.js";
-export { LoggableFernCliError } from "./LoggableFernCliError.js";
 export { createMockTaskContext } from "./MockTaskContext.js";
 export { TaskAbortSignal } from "./TaskAbortSignal.js";
 export {